Extend browsingContext.DownloadWillBegin with suggestedFilename
#890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Would r+ this, but it would be nice to have the cleanup and the new feature in separate commits, and given that the feature is waiting on HTML changes, perhaps even separate PRs. |
|
... and rename "WebDriver navigation status" to "WebDriver BiDi navigation status" to align with HTML spec. # Conflicts: # index.bs
sadym-chromium
force-pushed
the
sadym/suggested-filename
branch
from
829d8d4 to
b50b488
Compare
sadym-chromium
changed the title
browsingContext.DownloadWillBegin with suggestedFilenamebrowsingContext.DownloadWillBegin with suggestedFilename
jgraham
reviewed
Mar 21, 2025
sadym-chromium
force-pushed
the
sadym/suggested-filename
branch
from
cada355 to
399d50e
Compare
sadym-chromium
force-pushed
the
sadym/suggested-filename
branch
from
399d50e to
9aa865e
Compare
Lightning00Blade
approved these changes
Mar 21, 2025
I believe WebDriver BiDi specification should land first, ideally with WPT. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #840:
browsingContext.DownloadWillBeginwithsuggestedFilenameThe hook will be engaged in HTML spec after whatwg/html#11139 is merged.
Preview | Diff