Skip to content

Extend browser.createUserContext with unhandledPromptBehavior parameter #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sadym-chromium
Copy link
Contributor

@sadym-chromium sadym-chromium commented Apr 1, 2025

Addressing #789

Analogue of acceptInsecureCerts, add unhandledPromptBehavior parameter to browser.createUserContext.


Preview | Diff

@sadym-chromium sadym-chromium changed the title Specify browsingContext.setUnhandledUserPromptBehavior Extend browser.createUserContext with unhandledPromptBehavior parameter Apr 7, 2025
@burg
Copy link

burg commented Apr 22, 2025

I prefer the separate command that configures the session behavior, optionally for a user context. At least compared to a capability, it would make it easier to share implementations in WebKit. The current unhandledPromptBehavior capability is already quite complicated and I'm not sure why it has to be a capability anyway.

@sadym-chromium
Copy link
Contributor Author

I prefer the separate command that configures the session behavior, optionally for a user context. At least compared to a capability, it would make it easier to share implementations in WebKit. The current unhandledPromptBehavior capability is already quite complicated and I'm not sure why it has to be a capability anyway.

I'm not sure how having a separate command would ease the implementation, as we need to specify the behavior per user context.

@sadym-chromium sadym-chromium requested a review from OrKoN April 24, 2025 15:20
@sadym-chromium sadym-chromium marked this pull request as ready for review April 24, 2025 15:20
@sadym-chromium sadym-chromium force-pushed the sadym/browsingContext.setUnhandledUserPromptBehavior branch from eaf64d6 to 33c184a Compare May 12, 2025 08:20
@sadym-chromium sadym-chromium force-pushed the sadym/browsingContext.setUnhandledUserPromptBehavior branch from 680ce02 to 6174471 Compare May 14, 2025 13:50
@css-meeting-bot
Copy link
Member

The Browser Testing and Tools Working Group just discussed Extend `browser.createUserContext` with `unhandledPromptBehavior` parameter.

The full IRC log of that discussion <tidoust> Topic: Extend `browser.createUserContext` with `unhandledPromptBehavior` parameter
<tidoust> github: https://github.com//pull/896
<tidoust> sadym: After the first extension to createUserContext, I have a couple of new proposals which are PRs.
<tidoust> ... For unhandledPromptBehavior, two approaches are possible. Time to discuss and make a decision!
<jgraham> q+
<jimevans> ack next
<tidoust> jgraham: I agree that we shouldn't do more with capabilities here.
<tidoust> ... When we create a user context, at that point, you can specify unhandledPromptBehavior for the entire context, which is more fine-grained than what we have today, but less fine-grained than per browsing context.
<tidoust> ... It's not clear to me what the objection to this PR is. It seems fine. Later on, if we want to do it per browsing context, we can. For now, per user context seems a nice start to address use cases we know about without adding too much complexity.
<tidoust> jimevans: Seems that we can get to consensus on this one!
<tidoust> [no objection heard]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants