Skip to content

Fix perform and release actions for valid browsing context check and handle alert step #1877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whimboo merged 1 commit into from
Jan 31, 2025
Merged

Fix perform and release actions for valid browsing context check and handle alert step #1877

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10270,6 +10270,12 @@ <h3><dfn>Perform Actions</dfn></h3>
variables</var> and <var>parameters</var> are:

<ol class="algorithm">
<li><p>If <var>session</var>&apos;s <a>current browsing context</a>
is <a>no longer open</a>, return <a>error</a> with <a>error code</a>
<a>no such window</a>.

<li><p><a>Try</a> to <a>handle any user prompts</a> with <var>session</var>.

Comment on lines +10273 to +10278
Copy link
Contributor Author

@whimboo whimboo Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving this up as well given that there is no need to extract / process an action sequence when we have to fail anyway.

<li><p>Let <var>input state</var> be the result of <a>get the input
state</a> with <var>session</var>
and <var>session</var>&apos;s <a>current top-level browsing
Expand All @@ -10284,13 +10290,6 @@ <h3><dfn>Perform Actions</dfn></h3>
to <a>extract an action sequence</a> with <var>input state</var>,
<var>parameters</var>, and <var>actions options</var>.

<li><p>If <var>session</var>&apos;s <a>current browsing context</a>
is <a>no longer open</a>, return <a>error</a> with <a>error
code</a> <a>no such window</a>.

<li><p><a>Try</a> to <a>handle any user prompts</a>
with <var>session</var>.

<li><p><a>Dispatch actions</a> with <var>input state</var>,
<var>actions by tick</var>, <a>current browsing context</a>,
and <var>actions options</var>. If this results in an <a>error</a>
Expand Down Expand Up @@ -10331,6 +10330,8 @@ <h3><dfn>Release Actions</dfn></h3>
is <a>no longer open</a>, return <a>error</a> with <a>error
code</a> <a>no such window</a>.

<li><p><a>Try</a> to <a>handle any user prompts</a> with <var>session</var>.

<li><p>Let <var>input state</var> be the result of <a>get the input state</a>
with <a>session</a> and <a>current top-level browsing context</a>.

Expand Down