Skip to content

Conversation

@anshulWeb3
Copy link
Contributor

@anshulWeb3 anshulWeb3 commented Jan 23, 2024

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, an invoice must be submitted and the payment will be transferred to the Polkadot/fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1798

@semuelle semuelle self-assigned this Jan 23, 2024
Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @anshulWeb3, thanks for the new delivery. It is currently missing the Docker deliverable, could you add that please? Ideally, it would contain the whole setup including HRMP channels already. You can leverage Zombienet for this.

@anshulWeb3
Copy link
Contributor Author

anshulWeb3 commented Feb 8, 2024

Hi @semuelle We've integrated Trappist into our system, and you can find detailed information about it in the accompanying README located within the repository. For a more in-depth understanding and exploration of Trappist's features, please navigate to the Trappist branch. Link

Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @anshulWeb3, thanks for the update. I'm going through the readme in the trappist branch and noticed that you removed any mention of Linux: antiers-solutions/xnft@master...trappist#diff-b335630551. I happen to run Linux and don't have a Mac at hand; where do I find (or build) the Linux binaries?

@anshulWeb3
Copy link
Contributor Author

Sure @semuelle . Please let me know about the distro and the version of Linux that you are using so that we can provide the appropriate binaries to you. Thanks.

@semuelle
Copy link
Member

Sure @semuelle . Please let me know about the distro and the version of Linux that you are using so that we can provide the appropriate binaries to you. Thanks.

I run Ubuntu 22.04, but I'd prefer if you could point me to the code and build instructions so anyone can build it themselves.

@anshulWeb3
Copy link
Contributor Author

@semuelle please find the instructions here.

@anshulWeb3
Copy link
Contributor Author

Hi @semuelle. You can find the binaries for the same in the README of this repo. Thanks.

@anshulWeb3
Copy link
Contributor Author

Hello @semuelle . Do you have any updates for us regarding the delivery? Thanks.

@semuelle
Copy link
Member

@semuelle please find the instructions here.

Hey @anshulWeb3, I am looking for instructions how to build the binaries you are referring to in the trappist readme.

@anshulWeb3
Copy link
Contributor Author

Hello @semuelle
Greetings of the day.
Just wanted to check with you, is there is any progress on this grant. Are u able to build it? Is there any action pending from my side?
Please help me to take it forward!

@semuelle
Copy link
Member

@anshulWeb3, please see my previous comment: #1115 (comment). The readme is still referencing binary files. I would like to see the source for these and build them myself.

@anshulWeb3
Copy link
Contributor Author

Hi @semuelle . I think there is some confusion here. I had provided the link to the instructions in this comment and in this subsequent comment i had provided the required binaries, in case you were having issues creating them yourself. Please find the attached screenshot for the same here.
Screenshot from 2024-02-28 14-53-07

@semuelle
Copy link
Member

I had provided the link to the instructions in this comment

So, if I cargo build from the master branch, I get the polkadot, parachain-template-node and zombienet-linux binaries?

@anshulWeb3
Copy link
Contributor Author

Hi @semuelle . You will get the polkadot binary simply by cloning the repo provided in the link https://github.com/paritytech/polkadot/tree/release-v0.9.43 and running the command as
cargo build --release
For the parachain-template-node binary:
Simply clone the repo from link https://github.com/substrate-developer-hub/substrate-parachain-template/tree/polkadot-v0.9.40
You need to add pallets Frame nft and pallet xnft to your parachain node template. For integration of pallets in your chain you can refer to the link https://docs.substrate.io/tutorials/build-application-logic/add-a-pallet/
After adding the pallets to your parachain node template, Kindly build it using the following command
cargo build --release
For zombinet-linux binary :
You can directly download it from the link https://github.com/paritytech/zombienet/releases/
In this way you can build all the three binaries required for the testing enivironment.
After getting all the binaries please refer to step 4 of the instructions provided in the link https://github.com/antiers-solutions/xnft/blob/master/pallet-xnft/README.md?rgh-link-date=2024-02-13T13%3A10%3A44Z to do the complete setup of Relay-Para environment.

@semuelle
Copy link
Member

Thanks, I will try. In the meantime, could you add these instructions to the readme?

@anshulWeb3
Copy link
Contributor Author

Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, @anshulWeb3. Your milestone is hereby accepted.

It would have been very helpful if you had provided a Dockerfile with a working trappist + xnft setup. But given the long list of changes that have already been made since your first delivery, it's acceptable as is.

Best of luck going forward.

@semuelle semuelle merged commit 75fa927 into w3f:master Feb 29, 2024
@github-actions
Copy link

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

@semuelle
Copy link
Member

@anshulWeb3, the invoice you submitted a while ago doesn't contain the payment address, but bank details. Please submit a new one with the payment address included or amend the grant application with fiat info (see template for details).

@anshulWeb3
Copy link
Contributor Author

Hi @semuelle
We have filled the invoice form with the payment address included in invoice.Please acknowledge the same.Thanks.

@semuelle
Copy link
Member

Hi @semuelle
We have filled the invoice form with the payment address included in invoice.Please acknowledge the same.Thanks.

Confirmed.

@anshulWeb3
Copy link
Contributor Author

Hi @semuelle . Please share the Txn Hash once the payment is done so that i can confirm the same. Thanks.

@anshulWeb3
Copy link
Contributor Author

Hello @semuelle . Any updates regarding the processing of the payment?

@semuelle
Copy link
Member

semuelle commented Mar 8, 2024

Hi @anshulWeb3, apparently there are technical difficulties with the invoice. I expect it to be processed on Monday.

@anshulWeb3
Copy link
Contributor Author

Thanks @semuelle . Looking forward to it.

@anshulWeb3
Copy link
Contributor Author

Hi @semuelle . Waiting for your update regarding the same. Once done, please share the txn hash. Thanks.

Hi @anshulWeb3, apparently there are technical difficulties with the invoice. I expect it to be processed on Monday.

@anshulWeb3
Copy link
Contributor Author

Hi @semuelle . I quickly wanted to check with you. Is the payment processed?

@RouvenP
Copy link

RouvenP commented Mar 15, 2024

hi @anshulWeb3 we just sent the payment

@anshulWeb3
Copy link
Contributor Author

Thank you @RouvenP . Please share the transaction hash so that I can confirm the same.

@RouvenP
Copy link

RouvenP commented Mar 19, 2024

Sure, please see here

@anshulWeb3
Copy link
Contributor Author

Thanks @RouvenP . Verified from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants