Skip to content

Add substrate evm adapter milestone 1 #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

Conversation

dastanbeksamatov
Copy link
Contributor

@dastanbeksamatov dastanbeksamatov commented Mar 18, 2025

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#2292

@keeganquigley
Copy link
Contributor

Thanks @dastanbeksamatov is this ready to be evaluated? If so please flip it from "draft" mode. Thx.

@dastanbeksamatov dastanbeksamatov marked this pull request as ready for review March 27, 2025 23:35
@github-actions github-actions bot added the stale label Apr 11, 2025
@semuelle
Copy link
Member

Sorry for the wait, @dastanbeksamatov. I will review the delivery as soon as possible.

@semuelle semuelle removed the stale label Apr 14, 2025
@semuelle semuelle self-assigned this Apr 14, 2025
@dastanbeksamatov
Copy link
Contributor Author

Sorry for the wait, @dastanbeksamatov. I will review the delivery as soon as possible.

nw, thanks!

@dastanbeksamatov
Copy link
Contributor Author

ping :) @semuelle

@semuelle
Copy link
Member

Sorry again, @dastanbeksamatov! I will get back to you on Monday.

@semuelle
Copy link
Member

Hey @dastanbeksamatov . I didn't get around to checking all deliverables, I'll try to finish it tomorrow. But so far it looks good!

Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dastanbeksamatov. I get two failing tests, looks like there might be some hardcoded paths being checked against:

running 8 tests
test adapter::tests::test_pallet_mapping_works ... ok
test cache::tests::test_insert_and_retrieve ... ok
test cache::tests::test_capacity_limit ... ok
test adapter::tests::test_storage_key_works ... ok
test cache::tests::test_latest_block ... ok
test adapter::tests::test_hash_and_truncate ... ok
test tests::test_eth_rpc_light_client ... FAILED
test tests::test_eth_rpc_url ... FAILED

failures:

---- tests::test_eth_rpc_light_client stdout ----
Error: Binary not found at /Users/dastansamat/.cargo/target/debug/subeth

---- tests::test_eth_rpc_url stdout ----
Error: Binary not found at /Users/dastansamat/.cargo/target/debug/subeth

@dastanbeksamatov
Copy link
Contributor Author

Hey @dastanbeksamatov. I get two failing tests, looks like there might be some hardcoded paths being checked against:

running 8 tests
test adapter::tests::test_pallet_mapping_works ... ok
test cache::tests::test_insert_and_retrieve ... ok
test cache::tests::test_capacity_limit ... ok
test adapter::tests::test_storage_key_works ... ok
test cache::tests::test_latest_block ... ok
test adapter::tests::test_hash_and_truncate ... ok
test tests::test_eth_rpc_light_client ... FAILED
test tests::test_eth_rpc_url ... FAILED

failures:

---- tests::test_eth_rpc_light_client stdout ----
Error: Binary not found at /Users/dastansamat/.cargo/target/debug/subeth

---- tests::test_eth_rpc_url stdout ----
Error: Binary not found at /Users/dastansamat/.cargo/target/debug/subeth

just pushed the fix. apologies for the oversight

@dastanbeksamatov
Copy link
Contributor Author

Hey @dastanbeksamatov. I get two failing tests, looks like there might be some hardcoded paths being checked against:

running 8 tests
test adapter::tests::test_pallet_mapping_works ... ok
test cache::tests::test_insert_and_retrieve ... ok
test cache::tests::test_capacity_limit ... ok
test adapter::tests::test_storage_key_works ... ok
test cache::tests::test_latest_block ... ok
test adapter::tests::test_hash_and_truncate ... ok
test tests::test_eth_rpc_light_client ... FAILED
test tests::test_eth_rpc_url ... FAILED

failures:

---- tests::test_eth_rpc_light_client stdout ----
Error: Binary not found at /Users/dastansamat/.cargo/target/debug/subeth

---- tests::test_eth_rpc_url stdout ----
Error: Binary not found at /Users/dastansamat/.cargo/target/debug/subeth

just pushed the fix. apologies for the oversight

did it work? @semuelle

Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dastanbeksamatov, thanks for the quick fix. Yes, I am happy to report that the tests are all working now and your milestone is hereby accepted. You can find my evaluation notes here.

See you for the next one.

@semuelle semuelle merged commit e8eea5e into w3f:master Apr 30, 2025
6 checks passed
Copy link

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

Copy link

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we've created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation's guidelines in doing so. If you haven't already, reach out to [email protected] for feedback on your announcement and cross-promotion.

Thank you for your contribution, and good luck! If you have any remaining milestone, let us know if you encounter any delays by leaving a comment on the application PR or submitting an amendment.

@dastanbeksamatov
Copy link
Contributor Author

Hey @dastanbeksamatov, thanks for the quick fix. Yes, I am happy to report that the tests are all working now and your milestone is hereby accepted. You can find my evaluation notes here.

See you for the next one.

thanks for the evaluation! I've submitted the invoice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants