-
Notifications
You must be signed in to change notification settings - Fork 534
Add substrate evm adapter milestone 1 #1253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @dastanbeksamatov is this ready to be evaluated? If so please flip it from "draft" mode. Thx. |
Sorry for the wait, @dastanbeksamatov. I will review the delivery as soon as possible. |
nw, thanks! |
ping :) @semuelle |
Sorry again, @dastanbeksamatov! I will get back to you on Monday. |
Hey @dastanbeksamatov . I didn't get around to checking all deliverables, I'll try to finish it tomorrow. But so far it looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dastanbeksamatov. I get two failing tests, looks like there might be some hardcoded paths being checked against:
running 8 tests
test adapter::tests::test_pallet_mapping_works ... ok
test cache::tests::test_insert_and_retrieve ... ok
test cache::tests::test_capacity_limit ... ok
test adapter::tests::test_storage_key_works ... ok
test cache::tests::test_latest_block ... ok
test adapter::tests::test_hash_and_truncate ... ok
test tests::test_eth_rpc_light_client ... FAILED
test tests::test_eth_rpc_url ... FAILED
failures:
---- tests::test_eth_rpc_light_client stdout ----
Error: Binary not found at /Users/dastansamat/.cargo/target/debug/subeth
---- tests::test_eth_rpc_url stdout ----
Error: Binary not found at /Users/dastansamat/.cargo/target/debug/subeth
just pushed the fix. apologies for the oversight |
did it work? @semuelle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dastanbeksamatov, thanks for the quick fix. Yes, I am happy to report that the tests are all working now and your milestone is hereby accepted. You can find my evaluation notes here.
See you for the next one.
🪙 Please fill out the invoice form in order to initiate the payment process. Thank you! |
Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we've created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation's guidelines in doing so. If you haven't already, reach out to [email protected] for feedback on your announcement and cross-promotion. |
thanks for the evaluation! I've submitted the invoice |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#2292