-
Notifications
You must be signed in to change notification settings - Fork 581
Add Hyperfridge milestone 5 #1257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7550e27 to
25dcb46
Compare
|
hey @dastansam , |
|
Hi @dastansam is this still meant to be a draft? |
hey guys, will convert it to ready for review once I go through the final review, thanks! |
|
Hi @dastansam just checking in here, do you plan to finalize this delivery soon? |
yes, this week. apologies! |
|
hey @dastansam what's the status? |
|
pinging @dastansam |
Noc2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the status here? We would close the grant unless there is some progress.
hey there. we had an issue with the proof generation due to the outdated dependencies, so were working on fixing that. we will try to get the deliverable by the end of the week. apologies |
Hey @dastansam, any news on this? |
apologies again for the delay, it's ready for review |
|
Hey @dastansam , |
oh, forgot about that. working on it |
|
Let me know once it's available, thanks |
|
pinging @dastansam |
Updated Docker section to include usage instructions and added a new Article entry.
published the article and added it to the list of deliverables, thanks! 🙏 |
|
Thanks for the update and sorry for the delay on our side. Will get back to you with an update soon. @dastansam |
semuelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dastansam, thanks again for the delivery and sorry for the wait. cargo test is currently failing for me with the following error message. Could you look into it and let me know what needs to be done to fix this? Thanks!
error[E0407]: method `create_transaction` is not a member of trait `frame_system::offchain::CreateSignedTransaction`
--> pallets/fiat-ramps/src/mock.rs:165:2
|
165 | / fn create_transaction<C: frame_system::offchain::AppCrypto<Self::Public, Self::Signature>>(
166 | | call: RuntimeCall,
167 | | _public: <Signature as Verify>::Signer,
168 | | _account: AccountId,
... |
171 | | Some((call, (nonce, ())))
172 | | }
| |_____^ not a member of trait `frame_system::offchain::CreateSignedTransaction`
error[E0405]: cannot find trait `SendTransactionTypes` in module `frame_system::offchain`
--> pallets/fiat-ramps/src/mock.rs:153:33
|
153 | impl<C> frame_system::offchain::SendTransactionTypes<C> for Test
| ^^^^^^^^^^^^^^^^^^^^ not found in `frame_system::offchain`
warning: use of deprecated trait `sp_runtime::traits::Extrinsic`: Use `ExtrinsicLike` along with the `CreateTransaction` trait family instead
--> pallets/fiat-ramps/src/mock.rs:8:24
|
8 | traits::{BlakeTwo256, Extrinsic as ExtrinsicT, IdentifyAccount, IdentityLookup, Verify},
| ^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
warning: use of deprecated associated type `sp_runtime::traits::Extrinsic::SignaturePayload`: Use `ExtrinsicLike` along with the `CreateTransaction` trait family instead
--> pallets/fiat-ramps/src/mock.rs:170:55
|
170 | ) -> Option<(RuntimeCall, <Extrinsic as ExtrinsicT>::SignaturePayload)> {
| ^^^^^^^^^^^^^^^^
error[E0277]: the trait bound `mock::Test: CreateTransactionBase<pallet::Call<mock::Test>>` is not satisfied
--> pallets/fiat-ramps/src/mock.rs:139:29
|
139 | impl fiat_ramps::Config for Test {
| ^^^^ the trait `CreateTransactionBase<pallet::Call<mock::Test>>` is not implemented for `mock::Test`
|
= help: the trait `frame_system::offchain::CreateSignedTransaction<pallet::Call<mock::Test>>` is not implemented for `mock::Test`
but trait `CreateSignedTransaction<pallet::Call<_>>` is implemented for it
= note: required for `mock::Test` to implement `frame_system::offchain::CreateSignedTransaction<pallet::Call<mock::Test>>`
note: required by a bound in `pallet::Config`
--> pallets/fiat-ramps/src/lib.rs:87:43
|
87 | pub trait Config: frame_system::Config + CreateSignedTransaction<Call<Self>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `Config`
error[E0277]: the trait bound `mock::Test: CreateTransactionBase<LocalCall>` is not satisfied
--> pallets/fiat-ramps/src/mock.rs:161:80
|
161 | impl<LocalCall> frame_system::offchain::CreateSignedTransaction<LocalCall> for Test
| ^^^^ the trait `CreateTransactionBase<LocalCall>` is not implemented for `mock::Test`
|
note: required by a bound in `frame_system::offchain::CreateSignedTransaction`
--> /x/.cargo/git/checkouts/polkadot-sdk-dee0edd6eefa0594/b938705/substrate/frame/system/src/offchain.rs:475:2
|
474 | pub trait CreateSignedTransaction<LocalCall>:
| ----------------------- required by a bound in this trait
475 | CreateTransactionBase<LocalCall> + SigningTypes
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `CreateSignedTransaction`
error[E0046]: not all trait items implemented, missing: `create_signed_transaction`
--> pallets/fiat-ramps/src/mock.rs:161:1
|
161 | / impl<LocalCall> frame_system::offchain::CreateSignedTransaction<LocalCall> for Test
162 | | where
163 | | RuntimeCall: From<LocalCall>,
| |_________________________________^ missing `create_signed_transaction` in implementation
|
= help: implement the missing item: `fn create_signed_transaction<C>(_: <Self as CreateTransactionBase<LocalCall>>::RuntimeCall, _: <Self as frame_system::offchain::SigningTypes>::Public, _: <Self as frame_system::Config>::AccountId, _: <Self as frame_system::Config>::Nonce) -> std::option::Option<<Self as CreateTransactionBase<LocalCall>>::Extrinsic> where C: frame_system::offchain::AppCrypto { todo!() }`
Some errors have detailed explanations: E0046, E0277, E0405, E0407.
For more information about an error, try `rustc --explain E0046`.
warning: `fiat-ramps` (lib test) generated 2 warnings
error: could not compile `fiat-ramps` (lib test) due to 5 previous errors; 2 warnings emitted
warning: build failed, waiting for other jobs to finish...
|
pinging @dastansam |
working on the fix |
addressed review comments in the latest commit, thanks @semuelle |
semuelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dastansam, thanks for the update. I'm happy to report that the tests succeeded and that your milestone is hereby accepted. You can find my evaluation notes here.
|
🪙 Please fill out the invoice form in order to initiate the payment process. Please make sure that you follow the instructions and requirements as laid out in the form as well as our Terms & Conditions. Thank you! |
|
We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊 |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#2096