Skip to content

Conversation

@dastansam
Copy link
Contributor

@dastansam dastansam commented Apr 22, 2025

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#2096

@PieWol
Copy link
Member

PieWol commented May 8, 2025

hey @dastansam ,
I assume you intentionally opened a draft PR. We will look into it, once you mark it as ready for review.

@keeganquigley
Copy link
Contributor

Hi @dastansam is this still meant to be a draft?

@dastansam
Copy link
Contributor Author

Hi @dastansam is this still meant to be a draft?

hey guys,

will convert it to ready for review once I go through the final review, thanks!

@keeganquigley
Copy link
Contributor

Hi @dastansam just checking in here, do you plan to finalize this delivery soon?

@dastansam
Copy link
Contributor Author

Hi @dastansam just checking in here, do you plan to finalize this delivery soon?

yes, this week. apologies!

@github-actions github-actions bot added the stale label Jul 15, 2025
@PieWol PieWol assigned PieWol and unassigned PieWol Jul 15, 2025
@PieWol
Copy link
Member

PieWol commented Jul 15, 2025

hey @dastansam what's the status?

@github-actions github-actions bot added to close and removed stale labels Jul 30, 2025
@keeganquigley
Copy link
Contributor

pinging @dastansam

Copy link
Contributor

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the status here? We would close the grant unless there is some progress.

@dastansam
Copy link
Contributor Author

What is the status here? We would close the grant unless there is some progress.

hey there. we had an issue with the proof generation due to the outdated dependencies, so were working on fixing that. we will try to get the deliverable by the end of the week. apologies

@semuelle
Copy link
Member

we will try to get the deliverable by the end of the week. apologies

Hey @dastansam, any news on this?

@dastansam dastansam marked this pull request as ready for review September 26, 2025 17:25
@dastansam
Copy link
Contributor Author

we will try to get the deliverable by the end of the week. apologies

Hey @dastansam, any news on this?

apologies again for the delay, it's ready for review

@semuelle semuelle removed the to close label Oct 1, 2025
@PieWol PieWol self-assigned this Oct 6, 2025
@PieWol
Copy link
Member

PieWol commented Oct 17, 2025

Hey @dastansam ,
where can I find the article specified as deliverable 0e. of milestone 5 in the application document?

@dastansam
Copy link
Contributor Author

Hey @dastansam , where can I find the article specified as deliverable 0e. of milestone 5 in the application document?

oh, forgot about that. working on it

@PieWol
Copy link
Member

PieWol commented Oct 28, 2025

Let me know once it's available, thanks

@PieWol PieWol marked this pull request as draft November 6, 2025 12:59
@semuelle
Copy link
Member

pinging @dastansam

@semuelle semuelle self-assigned this Nov 12, 2025
Updated Docker section to include usage instructions and added a new Article entry.
@dastansam
Copy link
Contributor Author

dastansam commented Nov 18, 2025

pinging @dastansam

published the article and added it to the list of deliverables, thanks! 🙏

@github-actions github-actions bot added the stale label Dec 3, 2025
@dastansam dastansam marked this pull request as ready for review December 10, 2025 13:30
@PieWol
Copy link
Member

PieWol commented Dec 10, 2025

Thanks for the update and sorry for the delay on our side. Will get back to you with an update soon. @dastansam

Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dastansam, thanks again for the delivery and sorry for the wait. cargo test is currently failing for me with the following error message. Could you look into it and let me know what needs to be done to fix this? Thanks!

error[E0407]: method `create_transaction` is not a member of trait `frame_system::offchain::CreateSignedTransaction`
   --> pallets/fiat-ramps/src/mock.rs:165:2
    |
165 | /     fn create_transaction<C: frame_system::offchain::AppCrypto<Self::Public, Self::Signature>>(
166 | |         call: RuntimeCall,
167 | |         _public: <Signature as Verify>::Signer,
168 | |         _account: AccountId,
...   |
171 | |         Some((call, (nonce, ())))
172 | |     }
    | |_____^ not a member of trait `frame_system::offchain::CreateSignedTransaction`

error[E0405]: cannot find trait `SendTransactionTypes` in module `frame_system::offchain`
   --> pallets/fiat-ramps/src/mock.rs:153:33
    |
153 | impl<C> frame_system::offchain::SendTransactionTypes<C> for Test
    |                                 ^^^^^^^^^^^^^^^^^^^^ not found in `frame_system::offchain`

warning: use of deprecated trait `sp_runtime::traits::Extrinsic`: Use `ExtrinsicLike` along with the `CreateTransaction` trait family instead
 --> pallets/fiat-ramps/src/mock.rs:8:24
  |
8 |     traits::{BlakeTwo256, Extrinsic as ExtrinsicT, IdentifyAccount, IdentityLookup, Verify},
  |                           ^^^^^^^^^
  |
  = note: `#[warn(deprecated)]` on by default

warning: use of deprecated associated type `sp_runtime::traits::Extrinsic::SignaturePayload`: Use `ExtrinsicLike` along with the `CreateTransaction` trait family instead
   --> pallets/fiat-ramps/src/mock.rs:170:55
    |
170 |     ) -> Option<(RuntimeCall, <Extrinsic as ExtrinsicT>::SignaturePayload)> {
    |                                                          ^^^^^^^^^^^^^^^^

error[E0277]: the trait bound `mock::Test: CreateTransactionBase<pallet::Call<mock::Test>>` is not satisfied
   --> pallets/fiat-ramps/src/mock.rs:139:29
    |
139 | impl fiat_ramps::Config for Test {
    |                             ^^^^ the trait `CreateTransactionBase<pallet::Call<mock::Test>>` is not implemented for `mock::Test`
    |
    = help: the trait `frame_system::offchain::CreateSignedTransaction<pallet::Call<mock::Test>>` is not implemented for `mock::Test`
            but trait `CreateSignedTransaction<pallet::Call<_>>` is implemented for it
    = note: required for `mock::Test` to implement `frame_system::offchain::CreateSignedTransaction<pallet::Call<mock::Test>>`
note: required by a bound in `pallet::Config`
   --> pallets/fiat-ramps/src/lib.rs:87:43
    |
87  |     pub trait Config: frame_system::Config + CreateSignedTransaction<Call<Self>> {
    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `Config`

error[E0277]: the trait bound `mock::Test: CreateTransactionBase<LocalCall>` is not satisfied
   --> pallets/fiat-ramps/src/mock.rs:161:80
    |
161 | impl<LocalCall> frame_system::offchain::CreateSignedTransaction<LocalCall> for Test
    |                                                                                ^^^^ the trait `CreateTransactionBase<LocalCall>` is not implemented for `mock::Test`
    |
note: required by a bound in `frame_system::offchain::CreateSignedTransaction`
   --> /x/.cargo/git/checkouts/polkadot-sdk-dee0edd6eefa0594/b938705/substrate/frame/system/src/offchain.rs:475:2
    |
474 | pub trait CreateSignedTransaction<LocalCall>:
    |           ----------------------- required by a bound in this trait
475 |     CreateTransactionBase<LocalCall> + SigningTypes
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `CreateSignedTransaction`

error[E0046]: not all trait items implemented, missing: `create_signed_transaction`
   --> pallets/fiat-ramps/src/mock.rs:161:1
    |
161 | / impl<LocalCall> frame_system::offchain::CreateSignedTransaction<LocalCall> for Test
162 | | where
163 | |     RuntimeCall: From<LocalCall>,
    | |_________________________________^ missing `create_signed_transaction` in implementation
    |
    = help: implement the missing item: `fn create_signed_transaction<C>(_: <Self as CreateTransactionBase<LocalCall>>::RuntimeCall, _: <Self as frame_system::offchain::SigningTypes>::Public, _: <Self as frame_system::Config>::AccountId, _: <Self as frame_system::Config>::Nonce) -> std::option::Option<<Self as CreateTransactionBase<LocalCall>>::Extrinsic> where C: frame_system::offchain::AppCrypto { todo!() }`

Some errors have detailed explanations: E0046, E0277, E0405, E0407.
For more information about an error, try `rustc --explain E0046`.
warning: `fiat-ramps` (lib test) generated 2 warnings
error: could not compile `fiat-ramps` (lib test) due to 5 previous errors; 2 warnings emitted
warning: build failed, waiting for other jobs to finish...

@github-actions github-actions bot added the stale label Dec 26, 2025
@semuelle
Copy link
Member

semuelle commented Jan 8, 2026

pinging @dastansam

@dastansam
Copy link
Contributor Author

pinging @dastansam

working on the fix

@dastansam
Copy link
Contributor Author

pinging @dastansam

working on the fix

addressed review comments in the latest commit, thanks @semuelle

Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dastansam, thanks for the update. I'm happy to report that the tests succeeded and that your milestone is hereby accepted. You can find my evaluation notes here.

@semuelle semuelle merged commit a72a5de into w3f:master Jan 28, 2026
3 checks passed
@github-actions
Copy link

🪙 Please fill out the invoice form in order to initiate the payment process. Please make sure that you follow the instructions and requirements as laid out in the form as well as our Terms & Conditions. Thank you!

@github-actions
Copy link

We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊

So, where to from here? First of all, you should join our Grants Community chat, if you haven't already, so we can stay in touch.
If you are looking for continuative support for your project, there are quite a few options. The main goal of the W3F grants program is to support research as well as early-stage technical projects. If your project still falls under one of those categories, you might want to apply for a follow-up grant. However, depending on your goals and project status, there are other support programs in our ecosystem that might be better suited as the next step. For example, projects with a Business Case/Token should look into the Substrate Builders Program or VC Funding and Common Good projects have a good chance of receiving Treasury Funding. If you are looking for guidance, the team at https://substrate.io/ecosystem/square-one/ has compiled a list of ecosystem support sources and are happy to help you navigate it.

For a more comprehensive list, see our Alternative Funding page. Let us know if you have any questions regarding the above. We are more than happy to point you to additional resources and help you determine the best course of action.
Lastly, we hope your W3F grant was a success and we want to thank you for being part of the journey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants