-
Notifications
You must be signed in to change notification settings - Fork 32
STF Vectors #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
STF Vectors #28
Conversation
GP 0.6.4
ark-ec-vrfs version
I think there are some issue on WorkResult binary encoding. work_result_0.bin contains the following:
Inspecting the final part:
|
Before I dig in, these fields are using compact encoding. Have you checked that? |
My fault; I was using the size version of integer encoding. |
Suggestion to remove/adjust constraint here: jamtestvectors/codec/README.md Line 15 in 55b5950
Due to recent changes regarding use of Variable Length Integer Encoding. |
Hey davxy in the test
it seems correct on my end as this service appears in both note:
|
I think there is an issue with the new codec for ServiceActivityRecord. Some of the attributes are not in the correct order (due to typo in GP) So instead of
it should be
Exports moves up, and the two extrinsic ones need to be swapped. Please see gavofyork/graypaper#315 |
@davxy I think accumulate tests are not valid for 0.6.4, since the test service is compiled using jam-types==0.1.12, were the AccumulateItem is missing exports_root and authorizer_hash introduced with 0.6.4: https://docs.rs/jam-types/0.1.12/jam_types/struct.AccumulateItem.html |
Use gas alias consistently
Fix stats intems order according to GP 0.6.4
Improve disputes vectors
…kages Add Known Packages to the Reports STF Input
guarantees GuaranteesExtrinsic, | ||
|
||
-- [H_t] Block's timeslot. | ||
slot TimeSlot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add known_packages
GP Version 0.6.4
Keeping up to date all the PRs has become overwhelming.
This PR superseeds the previous STF vectors PRs.
In the future, the other PRs may be reopened to merge individual subsystems' STFs separately. For now, I prefer to consolidate everything into a single PR.
Partially address #21
Please file an Issue
If you have suggestions, issues, or requests for changes, please open an issue in the downstream fork: https://github.com/davxy/jam-test-vectors/issues.
Engaging in constructive discussions within this flat conversation thread is not the most efficient or agile approach.