Skip to content

Add batch transfers info - #6772

Merged
filippoweb3 merged 9 commits into
masterfrom
batch-transfers
Jul 7, 2025
Merged

Add batch transfers info#6772
filippoweb3 merged 9 commits into
masterfrom
batch-transfers

Conversation

@filippoweb3

Copy link
Copy Markdown
Contributor

No description provided.

@filippoweb3 filippoweb3 linked an issue Jul 7, 2025 that may be closed by this pull request
@filippoweb3 filippoweb3 added the A2 - Please Review Pull request is ready for review. label Jul 7, 2025
@filippoweb3
filippoweb3 requested a review from profradha July 7, 2025 12:12
@github-actions
github-actions Bot temporarily deployed to pull request July 7, 2025 12:13 Inactive
Comment thread docs/learn/learn-transactions.md Outdated
Comment thread docs/learn/learn-transactions.md Outdated
Comment thread docs/learn/learn-transactions.md Outdated
Comment thread docs/learn/learn-transactions.md Outdated
| Function | Stops on Error | Atomic | Events for Debugging |
|--------|--------|--------|--------|
| `batch`| Yes | No | Yes |
| `batchAll`| Yes | Yes | Not needed |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why it is not needed here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an "all or nothing" situation. No need to emit an event, as it will be 100% success or 100% failure

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a detailed table about events triggered for each case

Comment thread docs/learn/learn-transactions.md Outdated
Co-authored-by: Bill Laboon <laboon@users.noreply.github.com>
@github-actions
github-actions Bot temporarily deployed to pull request July 7, 2025 13:05 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request July 7, 2025 13:11 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request July 7, 2025 13:14 Inactive
Comment thread docs/learn/learn-transactions.md Outdated
Comment thread docs/learn/learn-transactions.md Outdated
Comment thread docs/learn/learn-transactions.md Outdated
filippoweb3 and others added 3 commits July 7, 2025 16:01
Co-authored-by: Bill Laboon <laboon@users.noreply.github.com>
Co-authored-by: Bill Laboon <laboon@users.noreply.github.com>
Co-authored-by: Bill Laboon <laboon@users.noreply.github.com>
@github-actions
github-actions Bot temporarily deployed to pull request July 7, 2025 14:05 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request July 7, 2025 14:44 Inactive
@filippoweb3 filippoweb3 removed the A2 - Please Review Pull request is ready for review. label Jul 7, 2025
@github-actions
github-actions Bot temporarily deployed to pull request July 7, 2025 15:14 Inactive
@filippoweb3
filippoweb3 merged commit f5541aa into master Jul 7, 2025
5 checks passed
@filippoweb3
filippoweb3 deleted the batch-transfers branch July 7, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compare different type of batches

2 participants