Prevent nextPos for connectEdges from accessing past end of array.#89
Open
terrencecrowley wants to merge 4 commits intow8r:masterfrom
Open
Prevent nextPos for connectEdges from accessing past end of array.#89terrencecrowley wants to merge 4 commits intow8r:masterfrom
terrencecrowley wants to merge 4 commits intow8r:masterfrom
Conversation
|
+1 for this merge request. I have the example, where martinez hangs out. This commit fixed problem. |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not certain whether this is a consequence of my previous bug fix, independent of that bug fix, or a revealed bug from that bug fix. In any case, the code prior to this fix was a bit sketchy since the top of the loop was checking that the incrementing variable was less than length of the array but the code inside the loop could already have used that variable to index into the array (which is where this crash was occurring). The change here is simply to only access the array if the index is less than the length.
I did not add an additional test case as my datasets that were triggering this bug are large and I needed to do some significant work to cull them down.