Overgrown PR: Session healing, playback transfer, go to album, view top tracks, and more#14
Open
Fiatsoft wants to merge 4 commits into
Open
Overgrown PR: Session healing, playback transfer, go to album, view top tracks, and more#14Fiatsoft wants to merge 4 commits into
Fiatsoft wants to merge 4 commits into
Conversation
Author
|
Updated (with commit 9b3ea80) to fix:
Also adds:
Rebased onto main and force-pushed (ready for review). |
Author
|
Can't request a review through UI, so hereby requesting one from @waaverecords when most convenient. Thank you for your time! Also: I am already considering (for a future PR) moving the device-transfer options from the SpotifyListPage's root context-menu to a separate ListPage or to a nested context-menu; let me know if you want me to make this change before this merge/review. |
Author
|
Follow-up: Updated (with commit 304e085) to:
Force-pushed with no plans for further updates to this PR. Details: "support for CommandResults settings" |
Author
|
Sanitized history by another |
… to album, add to queue, view top-tracks, User-name display, toasting, helper-oriented refactoring (for common track-list item context-menu), SpotifyListPage.cs file-name, etc
…rch, reset resource-string accessibility, edit ZH translation for session-healing (less technical)
…rnal static SpotifyCommandsProvider.SettingsManager), track-list helper command exclusions by Type-list
…enu items, fix Helpers.Track.ListItems command-filtering, CommandResults settings/naming-scheme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes multiple feature additions and improvements that I initially developed to explore how I could contribute meaningfully. It grew quickly, and I understand it may be too large to accept as-is — I’m happy to split it into smaller PRs or revise specific changes.
Notable features:
Other changes:
I've also merged the above with Picklesberg results filtering.
The interest in the project caught me off-guard so even if this PR is denied, I would like it to at least document my intentions. Please let me know if there’s anything you’d like revised, removed, 'tightened up' or better structured.