re-hook up file association so WJ can load modlists from double clicking .wabbajack file, and enable URL protocol for loading a modlist #2876
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a lot of the logic was already there, and this was implemented previously :
https://github.com/wabbajack-tools/wabbajack/pulls?q=is%3Apr+is%3Aclosed+file+association
it had issues like opening WJ in in system32 etc
ive mitigated that with forcing Windows to get current exe location to start in, and some robust handling incase it wants to start in System32 anyway
launch wj once for it to "heal" the current exe location and shove that into the windows registry for current user
tested and it runs any .wabbajack file by double clicking it, goes straight to install page as if you had selected "load modlist from file"
and I double checked wabbajack.exe location and where its running from and its not anywhere near system32
Also added handling for launching WJ via a special url protocol , format is wabbajack:/// so basically the machineurl for publishing, this will launch straight into the gallery, display a loading spinner while the wabbajack file is downloaded, and then launch into the install config
caveats:
WJ must be loaded at least once before hand, before file association or URL handling will work, as launching WJ will register those things
url handling only will deal with lists on the gallery ( for now ) with a machineurl
I want to add capability to embed a download url in the wabbajack:// url so it can prompt an external download of a WJ file