Merged
Conversation
|
✅ CI 통과했습니다!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
#️⃣ 작업 내용
zod 스키마
수정된 불일치 6건
#: 1
Schema: AlbumPostSchema
불일치 내용: likeCount, commentCount 누락
수정: 두 필드 추가, albums.tsx에서 하드코딩된 0 대신 실제 값 사용
────────────────────────────────────────
#: 2
Schema: ProfileUserSchema
불일치 내용: postsCount → 백엔드는 postCount
수정: 필드명 postCount로 변경, ProfilePage/ProfileHeader 반영
────────────────────────────────────────
#: 3
Schema: RecentSearchItemSchema
불일치 내용: name, isFollowed 필드가 백엔드에 없음
수정: 스키마에서 제거, UI에서 기본값(null, false) 전달
────────────────────────────────────────
#: 4
Schema: RecentSearchListResponseSchema
불일치 내용: items가 백엔드에서 nullable
수정: .nullable() 추가, API 함수에서 ?? [] 처리
────────────────────────────────────────
#: 5
Schema: FeedItemSchema
불일치 내용: thumbnailImageUrl이 백엔드에서 nullable
수정: .string().min(1) → .string().nullable(), FeedCard에서 null 처리
────────────────────────────────────────
#: 6
Schema: FollowUserSchema
불일치 내용: name 필드가 백엔드에 없음
수정: 스키마에서 제거, FollowListItem/FollowListModal UI 반영
수정된 파일 목록
mock handler
#: 1
Mock: user.ts profile: postsCount
Schema: ProfileUserSchema: postCount
불일치: 필드명
────────────────────────────────────────
#: 2
Mock: search.ts recent: name, isFollowed
Schema: RecentSearchItemSchema: 제거됨
불일치: 불필요 필드
────────────────────────────────────────
#: 3
Mock: types/follow.ts + toFollowUser.ts: name
Schema: FollowUserSchema: 제거됨
불일치: 불필요 필드
────────────────────────────────────────
#: 4
Mock: feed.ts: p.images?.[0] (undefined 가능)
Schema: FeedItemSchema: .nullable()
불일치: undefined vs null
#️⃣ 테스트 결과
#️⃣ 변경 사항 체크리스트
#️⃣ 스크린샷 (선택)
#️⃣ 리뷰 요구사항 (선택)
📎 참고 자료 (선택)