♻️ Consolidate multiple event detail pages into a single route#45
Merged
♻️ Consolidate multiple event detail pages into a single route#45
Conversation
…o refactor/event-detail
…o refactor/event-detail
young-52
approved these changes
Feb 4, 2026
Collaborator
young-52
left a comment
There was a problem hiding this comment.
더하여 아래 사항을 추가로 수정하였습니다.
- 일부 타입을 수정하였습니다.
- 소셜 로그인 시
AuthProvider는GOOGLE만 남겨 놓았습니다. JoinEventResponse타입은 노션의 API 명세를 참고하여 수정하였습니다.- 모집 시작·마감시각, 정원은 제8차 회의에서 null이 아닌 것으로 합의하였습니다. 노션에는 부분적으로 반영되지 않은 상태입니다.
- 소셜 로그인 시
- 타입 수정 과정에서 수반된 오류를 해결하였습니다.
EventPage→EventMain- 다른 라우트 이름에는
Page라는 단어를 쓰지 않았는데 일정 화면에만Page를 사용하는 것이 어색하여, 일정 메인 화면이라는 의미로EventMain이라는 이름으로 바꾸었습니다.
- 다른 라우트 이름에는
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
📸 스크린샷 (선택)
🚀 리뷰 요구사항 (선택)