Skip to content

소셜 로그인 연동#319

Merged
chaemin2001 merged 14 commits intomasterfrom
chaemin2001/social-login-connect
Jan 28, 2025
Merged

소셜 로그인 연동#319
chaemin2001 merged 14 commits intomasterfrom
chaemin2001/social-login-connect

Conversation

@chaemin2001
Copy link
Contributor

구글 & 카카오 계정 연동 추가

@chaemin2001 chaemin2001 requested a review from a team as a code owner October 30, 2024 13:55
Comment on lines 10 to 16
struct SocialProvider {
var local: Bool
var facebook: Bool
var google: Bool
var kakao: Bool
var apple: Bool
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이것도 let으로 해도 되지 않아?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q. 이 필드중에 여러개가 true일 가능성도 있는건가?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

웅 여러개 연동 되어있으면 전부 true!

Comment on lines 60 to 62
func connectKakao(kakaoToken: String) async throws ->
TokenResponseDto
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좀 사소하긴 한데 여기랑 line: 76 ~ 78 등 뭔가 줄바꿈이 다른 파트가 종종 있어서 이 코멘트랑 같이 반영해주면 좋을거같아용

Copy link
Contributor Author

@chaemin2001 chaemin2001 Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 그렇넹 오키!!

@chaemin2001 chaemin2001 merged commit 50ffbe3 into master Jan 28, 2025
4 checks passed
@chaemin2001 chaemin2001 deleted the chaemin2001/social-login-connect branch January 28, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants