최근 찾아본 학과 저장 by chaemin2001 · Pull Request #323 · wafflestudio/snutt-ios

chaemin2001 · 2025-01-01T12:20:56Z

일단 이렇게 구현해봤습니당 ..

SNUTT-2022/SNUTT/Views/Components/FilterSheetContent.swift

peng-u-0807 · 2025-01-01T13:04:38Z

SNUTT-2022/SNUTT/Views/Components/FilterSheetContent.swift

변경사항이 없어서 line에 직접 못적는데 좌측 태그 카테고리쪽 UI 변경사항도 같이 반영해주세용

그리고 필터 내부 스크롤이 안되는데(실기기&시뮬레이터 둘다 iOS 18.0+) 혹시 재현돼?
시뮬레이터 iOS 17.2에서는 문제 없는거같긴해

xcode 16 + ios 18 에서 highPriorityGesture 문제 있는듯..
snutt 2024에서는 고쳐놨는데 ㅋㅋ..

ㅇㅋ 색상이랑 폰트 크기 이런거 말하는거 맞지?

엉 그거랑 내부 스크롤 안되는 문제도..!

스크롤 문제는

snutt-ios/SNUTT/Modules/Shared/SharedUIComponents/Sources/Sheet/Sheet+Gesture.swift

Lines 12 to 23 in 7273019

func sheetGesture(_ translation: Binding<CGFloat>, dismiss: @escaping @MainActor () -> Void) -> some View {

if #available(iOS 18.0, *) {

gesture(SheetGestureRecognizer(translation: translation, dismiss: dismiss))

} else {

highPriorityGesture(DragGesture().onChanged({ value in

translation.wrappedValue = value.translation.width

}).onEnded({ value in

translation.wrappedValue = 0

if value.velocity.width < -300 || value.translation.width < -100 {

dismiss()

}

}))

여기 참고하면 될듯!

참고해서 고쳤는데 이게 위로 스크롤 시에 sheet가 dismiss되는 문제가 있는데 .. 실기기에서도 똑같겠지 ..?ㅜㅜ

아하. 이거는 bottom sheet구나. 그러면 저 코드에서 value.velocity.width 랑 translation.width 를 height로 바꿔야할듯! x는 y로 바꾸고.

SNUTT-2022/SNUTT/Services/SearchService.swift

shp7724 · 2025-02-02T12:21:38Z

SNUTT-2022/SNUTT/Views/Components/Sheet.swift


                VStack(spacing: 0) {
                    self.content()
+                        .simultaneousGesture(DragGesture())


이건뭔가용

스크롤하면서 학과 선택 계속 눌리길래!

SNUTT-2022/SNUTT/Services/SearchService.swift

peng-u-0807 · 2025-02-07T05:21:38Z

SNUTT-2022/SNUTT/Services/SearchService.swift

+        }
+        var updatedTags = departmentTags + appState.search.pinnedTagList
+        if updatedTags.count > 5 {
+            updatedTags = Array(updatedTags.suffix(5))


Suggested change

updatedTags = Array(updatedTags.suffix(5))

updatedTags = Array(updatedTags.prefix(5))

아래가 잘려야하니 prefix가 기획상 맞을 듯..?

Co-authored-by: Yoorim Choi <penguin0807@snu.ac.kr>

* Add Theme Market Web View * Add "Downloaded" Theme Section * Add Theme Market Webview * Fix Cookie Setting * Add Navigation Bar * Apply SwiftFormat changes * Fix: do not show `categoryPre2025` before 2025 (#332) * Fix: do not show `categoryPre2025` before 2025 * Apply SwiftFormat changes --------- Co-authored-by: peng-u-0807 <peng-u-0807@users.noreply.github.com> * 최근 찾아본 학과 저장 (#323) * Add Pinned Department * Apply SwiftFormat changes * Resolve Font Problems * UI Adjustments * Resolve Non-Scrolling Behavior for ios18 * Apply SwiftFormat changes * Update View+Gesture.swift * Xcode `15.1` -> `16.0` * Apply SwiftFormat changes * Xcode `16.0` -> `16.2` * Fix Sheet Dismiss Bug * Update SNUTT-2022/SNUTT/Services/SearchService.swift Co-authored-by: Yoorim Choi <penguin0807@snu.ac.kr> * Update SearchService.swift --------- Co-authored-by: chaemin2001 <chaemin2001@users.noreply.github.com> Co-authored-by: peng-u-0807 <penguin0807@snu.ac.kr> Co-authored-by: peng-u-0807 <peng-u-0807@users.noreply.github.com> * Enable tap gesture for `ratingSection` (#328) * Enable tap gesture for `ratingSection` * Fix typo * Show tip for iOS 17.0+ * Apply SwiftFormat changes * Remove debug print --------- Co-authored-by: peng-u-0807 <peng-u-0807@users.noreply.github.com> * 팝업 모듈 구현 (#329) * Fix `.lectureUpdate` deeplink not working (#334) Add URLSchemes * Upgrade `FirebaseSDK` version * `LectureEditDetailScene`에 카카오맵 추가 (#333) * Fix lecture map not opening external app (#337) * 팝업에 링크 추가 (#336) * Add linkUrl to Popups * Apply SwiftFormat changes --------- Co-authored-by: chaemin2001 <chaemin2001@users.noreply.github.com> * 🪴 로그 심기 (#335) * Firebase SDK 업데이트 * Dev 스킴에 Firebase SDK 디버그 옵션 추가 * Automatic Screen Tracking 해제 * Analytics 관련 모델 정의 * pbxproj 업데이트 * Analytics 로깅 추가 * Apply SwiftFormat changes * Xcode 버전 16.1로 변경 --------- Co-authored-by: shp7724 <shp7724@users.noreply.github.com> * Delete unnecessary code * Add Theme Market Web View * Add "Downloaded" Theme Section * Add Theme Market Webview * Fix Cookie Setting * Add Navigation Bar * Apply SwiftFormat changes * Delete unnecessary code * Apply SwiftFormat changes * Delete repeating lines * Enable ThemeMarketView Bounce * Fix Bug of ColorScheme EventSignal * Change `ThemeBottomSheet` height * Apply SwiftFormat changes --------- Co-authored-by: chaemin2001 <chaemin2001@users.noreply.github.com> Co-authored-by: Yoorim Choi <penguin0807@snu.ac.kr> Co-authored-by: peng-u-0807 <peng-u-0807@users.noreply.github.com> Co-authored-by: shinhong_park <shp7724@snu.ac.kr> Co-authored-by: shp7724 <shp7724@users.noreply.github.com>

Add Pinned Department

86ded70

chaemin2001 requested a review from a team as a code owner January 1, 2025 12:20

chaemin2001 and others added 3 commits January 1, 2025 21:23

Merge branch 'master' into chaemin2001/pin-recent-searched-departments

af41ada

Apply SwiftFormat changes

8a6f9a8

Resolve Font Problems

13b903a

peng-u-0807 reviewed Jan 1, 2025

View reviewed changes

UI Adjustments

9fd870b

peng-u-0807 reviewed Jan 4, 2025

View reviewed changes

SNUTT-2022/SNUTT/Services/SearchService.swift Outdated Show resolved Hide resolved

chaemin2001 and others added 4 commits January 7, 2025 15:25

Resolve Non-Scrolling Behavior for ios18

9b9215b

Apply SwiftFormat changes

6363d67

Update View+Gesture.swift

5920db6

Xcode 15.1 -> 16.0

41ddcbc

peng-u-0807 force-pushed the chaemin2001/pin-recent-searched-departments branch from d72e44c to 41ddcbc Compare January 14, 2025 04:54

peng-u-0807 and others added 3 commits January 14, 2025 04:54

Apply SwiftFormat changes

c6903fd

Xcode 16.0 -> 16.2

26224ef

Delete files to merge conflicts

ce47ace

peng-u-0807 assigned chaemin2001 Jan 27, 2025

peng-u-0807 changed the title ~~선호 학과 정보 저장~~ 최근 찾아본 학과 저장 Jan 27, 2025

chaemin2001 added 2 commits February 2, 2025 17:13

Fix Sheet Dismiss Bug

baa7299

Merge branch 'master' into chaemin2001/pin-recent-searched-departments

5cc48f7

shp7724 reviewed Feb 2, 2025

View reviewed changes

peng-u-0807 reviewed Feb 7, 2025

View reviewed changes

chaemin2001 and others added 2 commits February 8, 2025 11:12

Update SNUTT-2022/SNUTT/Services/SearchService.swift

08e521c

Co-authored-by: Yoorim Choi <penguin0807@snu.ac.kr>

Update SearchService.swift

343ffd8

peng-u-0807 approved these changes Feb 9, 2025

View reviewed changes

chaemin2001 merged commit 042bea3 into master Feb 9, 2025
4 checks passed

chaemin2001 deleted the chaemin2001/pin-recent-searched-departments branch February 9, 2025 05:47

	func sheetGesture(_ translation: Binding<CGFloat>, dismiss: @escaping @MainActor () -> Void) -> some View {
	if #available(iOS 18.0, *) {
	gesture(SheetGestureRecognizer(translation: translation, dismiss: dismiss))
	} else {
	highPriorityGesture(DragGesture().onChanged({ value in
	translation.wrappedValue = value.translation.width
	}).onEnded({ value in
	translation.wrappedValue = 0
	if value.velocity.width < -300 \|\| value.translation.width < -100 {
	dismiss()
	}
	}))

	updatedTags = Array(updatedTags.suffix(5))
	updatedTags = Array(updatedTags.prefix(5))

Conversation

chaemin2001 commented Jan 1, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants