Merged
Conversation
팝업 이미지를 탭하면 연결된 URL을 열 수 있도록 구현
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds clickable link functionality to popup images. When a popup has an associated URL, tapping the image will open that URL in the browser.
Key Changes:
- Added
linkURLfield to popup data models to store associated URLs - Implemented tap gesture handler on popup images that opens the link URL when available
- Updated repository layer to parse and map link URLs from API responses
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| PopupView.swift | Added tap gesture to popup image that opens link URL using application dependency |
| PopupAPIRepository.swift | Updated API response mapping to include linkURL field from server |
| LiveDependencies.swift | Updated preview data to include nil linkURL for test popup |
| ServerPopup.swift | Added linkURL property to domain model |
| PopupModel.swift | Added computed property to expose linkURL from ServerPopup |
| await application.open(linkURL) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
The tap gesture lacks accessibility support. Consider adding .accessibilityHint() to inform screen reader users that the popup image is tappable and will open a link, and .accessibilityAddTraits(.isButton) to indicate it's an interactive element.
Suggested change
| } | |
| } | |
| .accessibilityHint("이미지를 탭하면 링크가 열립니다.") // "Tapping the image will open a link." | |
| .accessibilityAddTraits(.isButton) |
스크린 리더 사용자를 위한 힌트 및 버튼 trait 추가
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
팝업 이미지를 탭하면 연결된 URL을 열 수 있도록 구현
Related: #336