Merged
Conversation
SeonghaeJo
requested review from
Hank-Choi,
asp345 and
davin111
and removed request for
a team
Hank-Choi
approved these changes
Jan 7, 2025
Comment on lines
170
to
193
| RouterOperation( | ||
| path = "/v1/auth/login_apple", | ||
| method = [RequestMethod.POST], | ||
| produces = [MediaType.APPLICATION_JSON_VALUE], | ||
| operation = | ||
| Operation( | ||
| operationId = "loginAppleLegacy", | ||
| requestBody = | ||
| RequestBody( | ||
| content = [ | ||
| Content( | ||
| schema = Schema(implementation = SocialLoginRequest::class), | ||
| mediaType = MediaType.APPLICATION_JSON_VALUE, | ||
| ), | ||
| ], | ||
| ), | ||
| responses = [ | ||
| ApiResponse( | ||
| responseCode = "200", | ||
| content = [Content(schema = Schema(implementation = LoginResponse::class))], | ||
| ), | ||
| ], | ||
| ), | ||
| ), |
Member
There was a problem hiding this comment.
레거시는 레거시니까 docs에서 빼주세요
괜히 두개 있으면 위에꺼 쓸 수도 있고 더 헷갈려요
Comment on lines
59
to
60
| val kid = headerMap["kid"] as? String ?: throw IllegalArgumentException("유효하지 않은 애플 로그인 토큰") | ||
| val alg = headerMap["alg"] as? String ?: throw IllegalArgumentException("유효하지 않은 애플 로그인 토큰") |
Member
There was a problem hiding this comment.
예상 가능한 상황이니 Snu4tException 만들어서 던지는건 어떨까요
Comment on lines
61
to
64
| return mapOf( | ||
| "kid" to kid, | ||
| "alg" to alg, | ||
| ) |
Member
There was a problem hiding this comment.
이것도 AppleClient 내부에 internal data class 만들어서 관리하면 좋을 것 같아요
asp345
approved these changes
Jan 9, 2025
Hank-Choi
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppleClient수정extractJwtHeader메서드 수정: signing key 명시하지 않으면 에러가 발생하여 base64 디코딩으로 헤더 추출webClient.get에 사용되는 타입 수정login_apple레거시 엔드포인트 추가