Skip to content

Fix: member 중복 이름 수정#140

Merged
mjy926 merged 1 commit into
developfrom
fix-member-response
May 28, 2026
Merged

Fix: member 중복 이름 수정#140
mjy926 merged 1 commit into
developfrom
fix-member-response

Conversation

@mjy926

@mjy926 mjy926 commented May 26, 2026

Copy link
Copy Markdown
Contributor

이름이 중복으로 반환되는 문제가 있어서 id 기준으로도 정렬하도록 수정했습니다.

@mjy926 mjy926 requested a review from a team as a code owner May 26, 2026 02:59
@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b94aa881-030c-4083-89ef-7f63917fed9b

📥 Commits

Reviewing files that changed from the base of the PR and between a6c3b1e and e795b7b.

📒 Files selected for processing (1)
  • wacruit/src/apps/member/repositories.py

📝 Walkthrough

동작 설명

Member 저장소 개선

계층 / 파일(s) 요약
Import 재정렬
wacruit/src/apps/member/repositories.py
SQLAlchemy 및 데이터베이스 import들의 순서가 재정렬되었습니다.
Member 쿼리 정렬 기준 추가
wacruit/src/apps/member/repositories.py
get_all_members의 정렬 조건에 Member.id.asc()를 추가하여 동일한 생성값이나 포지션을 가진 행들의 반환 순서를 일관되게 고정합니다.

예상 코드 리뷰 난이도

🎯 2 (Simple) | ⏱️ ~5-10분

제안 리뷰어

  • MunJaeyoung
  • deveroskp
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed PR 제목은 멤버 관련 문제 해결에 대해 언급하지만, 실제 변경사항인 정렬 기준 추가(id 기반 정렬)를 구체적으로 설명하지 않습니다.
Description check ✅ Passed PR 설명이 변경사항과 관련이 있으며, 중복 이름 반환 문제 해결을 위해 id 기준 정렬을 추가했음을 명확히 설명하고 있습니다.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-member-response

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mjy926 mjy926 merged commit 6edc143 into develop May 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants