fix(docker): use canonical Windows named-pipe URL#710
Open
toller892 wants to merge 1 commit into
Open
Conversation
The default Windows Docker host was set to "npipe:////.pipe/docker_engine". The Docker client library treats the leading "//.pipe/..." segment as part of the URL path and percent-encodes the slashes, producing requests like "http://%2F%2F.pipe%2Fdocker_engine/..." which then fail with "The filename, directory name, or volume label syntax is incorrect.". This affects Rancher Desktop on Windows (with WSL integration), which exposes the engine via the named pipe \\.\pipe\docker_engine and is therefore unreachable from dive using the previous default. Switch the default to Moby's canonical Windows pipe URL "npipe:////./pipe/docker_engine" (the same value used by client.DefaultDockerHost in moby/moby) so the path is preserved verbatim and the docker client connects to the named pipe correctly. Add build-tagged tests pinning the constant value so future changes to the default are caught. Fixes wagoodman#649
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default Windows Docker host was set to
npipe:////.pipe/docker_engine. The Docker client library treats the leading//.pipe/...segment as part of the URL path and percent-encodes the slashes, producing requests likehttp://%2F%2F.pipe%2Fdocker_engine/...which then fail withThe filename, directory name, or volume label syntax is incorrect.This affects Rancher Desktop on Windows (with WSL integration), which exposes the engine via the named pipe and is therefore unreachable from dive using the previous default.
Switch the default to Moby's canonical Windows pipe URL
npipe:////./pipe/docker_engine(the same value used byclient.DefaultDockerHostin moby/moby) so the path is preserved verbatim and the docker client connects to the named pipe correctly.Add build-tagged tests pinning the constant value so future changes to the default are caught.
Fixes #649