Maintenance update: switch to pyproject.toml, format with Black, add back coverage report, Wagtail 7.3 - #101
Merged
Conversation
- Drop Python 3.8 and 3.9 (end of life) - Add Python 3.13 and 3.14 - Drop Django 4.2, 5.0 and 5.1 - Add Django 5.2 and 6.0 - Drop Wagtail 5.2, 6.0, 6.1, 6.2, 6.3 and 6.4 - Add Wagtail 7.0, 7.3 LTS and 7.4
PyFilesystem2 (fs), pulled in transitively via django-bakery, still calls `pkg_resources.declare_namespace(__name__)` at import time. setuptools 81 deprecated `pkg_resources` and 82 dropped it from the wheel, so `import fs` explodes with `ModuleNotFoundError: No module named 'pkg_resources'` on fresh Python 3.14 envs. Pin setuptools<81 until upstream `fs` ships a fix.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
======================================
Coverage ? 70.5%
======================================
Files ? 6
Lines ? 210
Branches ? 19
======================================
Hits ? 148
Misses ? 55
Partials ? 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
g-nie
marked this pull request as ready for review
May 1, 2026 21:51
g-nie
commented
May 1, 2026
Comment on lines
+49
to
+51
| # `fs` (transitive via django-bakery) still calls pkg_resources.declare_namespace, | ||
| # which setuptools 81+ removed. Pin until PyFilesystem2 ships a fix. | ||
| "setuptools<81", |
Contributor
Author
There was a problem hiding this comment.
Just commenting for more visibility. With setuptools >= 81 tox raises ModuleNotFoundError: No module named 'pkg_resources'. I might bring this up with django-bakery.
Stormheg
reviewed
May 3, 2026
| # See https://git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs-fileltfilegt | ||
|
|
||
| # Reformat with Black | ||
| 8c2fff90dd68190cc52563459fd95c59b26b919e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Maintenance sweep mirroring #97, refreshed for the current versions.
Thanks @Stormheg for the initial work!
setup.py/setup.cfgtopyproject.toml(setuptools build backend), bump version to0.9.0.codecov.yml,coverageconfig inpyproject.toml).make formattarget and aLintjob in CI.setuptools<81in thetestextra sofs(transitive viadjango-bakery) keeps working until PyFilesystem2 stops callingpkg_resources.declare_namespace.