Skip to content

Update and move to Wagtail Nest - #63

Merged
Stormheg merged 38 commits into
mainfrom
wagtail-nest
Apr 18, 2026
Merged

Update and move to Wagtail Nest#63
Stormheg merged 38 commits into
mainfrom
wagtail-nest

Conversation

@Stormheg

Copy link
Copy Markdown
Member

Includes changes from #62

See discussion in #51


This PR implements many of the changes needed to move the package to Wagtail Nest. The package itself was already transfered to the Wagtail Nest organization in December 2024 by Springload. I now have found the time to make the remaining changes necessary to make it all official.

Thanks to @haydngreatnews from Springload for his help to make the transfer happen.

I've made a bunch of changes to make the package more 'modern' for the year 2025.

  • Convert from setup.py to pyproject.toml
  • Use pre-commit
  • Use ruff instead of flake8 and isort. The config is based on the one now being used for wagtail.org, see Switch to ruff for linting wagtail/wagtail.org#488
  • Use PyPI Trusted Publishing to automate publishing new releases. I've already set up the trusted publisher on the PyPI project page.
  • Update the tox configuration; drop and add currently supported Wagtail and Django versions
  • Set up nightly tests. Test the package against the latest development versions of Wagtail, Django and django-recaptcha to catch incompatibilities early.

nickmoreton and others added 26 commits November 14, 2024 15:09
And update the supported Django and Wagtail versions and classifiers.
I set the dependency to wagtail>=5.0 becuase thats what the testing is run against.
And implement flake8 and isort rules through ruff.
- Ruff format
- End of line fixes
- Pretty JSON
>  error: Multiple top-level packages discovered in a flat-layout: ['wagtailcaptcha', 'coverage_html_report'].
Rely on pre-commit to run linters and formatters
Drop unsupported versions of Wagtail and Django, add new ones
@codecov

codecov Bot commented Feb 20, 2025

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Can't set it up - not available for open source anymore? Signup now
requires an invite.
@Stormheg
Stormheg marked this pull request as ready for review February 20, 2025 15:24
@Stormheg

Copy link
Copy Markdown
Member Author

Not sure what this is. Hope it goes away once the new CI setup is merged.

afbeelding

Otherwise the fixtures won't load since locale_id is required!

@g-nie g-nie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good to me. I'm leaving some comments for version bumps that were introduced since the PR was originally created.

Comment thread .github/workflows/nightly-tests.yml Outdated
Comment thread .github/workflows/nightly-tests.yml Outdated
Comment thread .github/workflows/nightly-tests.yml Outdated
Comment thread .github/workflows/test.yml Outdated
Comment thread .pre-commit-config.yaml Outdated
Comment thread pyproject.toml Outdated
Comment thread pyproject.toml Outdated
Comment thread pyproject.toml Outdated
Comment thread tox.ini Outdated
Comment thread tox.ini
@Stormheg
Stormheg merged commit f6a6617 into main Apr 18, 2026
8 checks passed
@Stormheg
Stormheg deleted the wagtail-nest branch April 18, 2026 13:23

@g-nie g-nie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants