Prevent adding duplicate reviewers - #15
Open
yedpodtrzitko wants to merge 1 commit into
Open
Conversation
yedpodtrzitko
force-pushed
the
enforce-unique-reviewer
branch
from
August 24, 2019 02:22
c5e802e to
5f537cd
Compare
yedpodtrzitko
force-pushed
the
enforce-unique-reviewer
branch
from
August 24, 2019 02:24
5f537cd to
bb17d7e
Compare
yedpodtrzitko
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #7
when the review submitter adds himself in the review form manually, it will add him twice, which will end up with the error reported in #7 .
Checking for the user in POST data should mitigate it.
Enforcing uniqueness via DB constraint should prevent the cause rather than dealing with consequences.