Wagtail 7.4 LTS maintenance by nickmoreton · Pull Request #921 · wagtail/wagtail-localize

nickmoreton · 2026-05-13T10:53:29Z

Summary

Align the supported version matrix with the current Wagtail / Django / Python support windows: drop Wagtail 6.3 (EOL 2026-05-01), keep 7.0 LTS / 7.2 / 7.3, add 7.4 LTS. Wagtail 7.1 is excluded — it was a non-LTS feature release that has already aged out of support. Minimum Wagtail is now 7.0.
Drop Django 4.2 (EOL April 2026) — minimum Django is now 5.1. This also dodges the wagtail-modeladmin 2.3.0 regression that only fires on Django <5.0.
Refresh the tox matrix accordingly (Django 5.1 / 5.2 / 6.0 across Python 3.10–3.14) and update classifiers, README, and CHANGELOG.
Remove stale WAGTAIL_VERSION / DJANGO_VERSION compatibility guards that no longer cover any supported version.
Fix a Wagtail 7.3+ regression in Translation.save_target() that raised IntegrityError on (translation_key, locale_id) when translating snippets with nested TranslatableMixin cluster grandchildren. Wagtail's CopyForTranslationAction only re-locales the top tier of the returned cluster; the workaround walks the cluster after copy_for_translation and re-assigns the target locale on every nested descendant.
Modernise non-production tooling: Python docs/testing extras, pre-commit hook revs (ruff 0.15.12, ruff-check id), GitHub Actions majors, and the Node build stack (webpack 5, TypeScript 5, drop file-loader in favour of webpack 5 asset modules).
Fix the tox-gh-actions postgres factor mapping (postgres → postgres15) so the matrix entries actually run instead of falling back to the default py env.

Commits, in order:

dc3b7cc Add Wagtail 7.4 LTS support, drop Wagtail 6.3
f32bcd0 Remove Wagtail 7.1 from the supported version range
725ea4a Update Python documentation and testing dev dependencies
c24eb4f Bump pre-commit hook versions
f17ed81 Bump GitHub Actions to current majors
b5d5541 Bump Node build tooling to webpack 5 / TypeScript 5
410ff23 Fix tox-gh-actions postgres env factor mapping
5947e94 Fix nested-cluster locale on snippet translation save
ac77fdf Drop Django 4.2 support

Deliberately deferred

mirrors-prettier rev bump — the only newer rev is v4.0.0-alpha.8 on an archived mirror; will be handled separately by switching to rbubley/mirrors-prettier.
React 18 / styled-components 6 migration — bumping @types/react to 18 surfaces a known incompatibility with @types/styled-components@5; needs a dedicated styled-components 6 migration.
eslint hook additional_dependencies are still pinned to ancient versions; tied to the React/styled-components migration above.
Upstream Wagtail fix for nested-cluster locale assignment in CopyForTranslationAction — should be filed against wagtail/wagtail so the workaround in models.py can eventually be retired.

Test plan

tox -e python3.13-django5.2-wagtail7.4-postgres15 (primary new combination)
tox -e python3.10-django5.1-wagtail7.0-postgres15 (lower bound)
tox -e python3.14-django6.0-wagtail7.4-postgres15 (upper bound)
tox -e wagtailmain
pre-commit run --all-files
npm ci && npm run build (webpack 5 bundle output sanity-checked)
Load the built admin bundle in a Wagtail 7.4 instance and exercise the translation UI
mkdocs build --strict (docs extras had several major bumps)

🤖 Generated with Claude Code

- Raise minimum Wagtail to 7.0 (6.3 LTS reached EOL 2026-05-01). - Add Wagtail 7.1, 7.3 and 7.4 (LTS) to the tox matrix; add Django 5.1. - Update classifiers: drop "Framework :: Wagtail :: 6", add "Framework :: Django :: 6.0". - Remove stale WAGTAIL_VERSION / DJANGO_VERSION compatibility guards that targeted versions outside the supported range. - Update README "Requirements" section and add a CHANGELOG entry under Unreleased. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Wagtail 7.1 is not in the Wagtail support window (only 7.0 LTS, 7.2, 7.3 and 7.4 LTS are currently supported). 7.2 has just exited active support but remains kept for the current release cycle. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

- mkdocs: pin 1.4.3 -> >=1.6,<2 (current series). - mkdocs-material: minimum bumped to 9.5. - mkdocstrings[python]: 0.22.0 -> >=0.26 (1.x now available). - mkdocs-autorefs: 0.4.x -> >=1.0,<2. - mkdocs-include-markdown-plugin: 4.x -> >=7.0,<8. - pygments: drop unnecessary <2.16 cap. - dj-database-url: allow <4 (currently 3.x). - django-rq: allow <5 (currently 4.x). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

- pre-commit-hooks: v5.0.0 -> v6.0.0. - ruff-pre-commit: v0.11.8 -> v0.15.12; rename the `ruff` hook to `ruff-check` (the new canonical id; `ruff` is now a legacy alias). - mirrors-eslint: v8.1.0 -> v10.3.0. Additional dependencies are kept pinned to the existing versions because they track the Node admin bundle, which will be updated separately. - Sync `.github/workflows/ruff.yml` to ruff 0.15.12. `mirrors-prettier` is left at v2.7.1: the upstream mirror is archived and the only newer rev is `v4.0.0-alpha.8`, which would reformat the codebase wholesale and pull in a Prettier alpha. The prettier migration will be handled in a dedicated commit. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

- actions/checkout: v4 -> v6 - actions/setup-python: v5 -> v6 - actions/setup-node: v4 -> v6 - actions/upload-artifact: v4 -> v7 - actions/download-artifact: v4 -> v8 - codecov/codecov-action: v4 -> v6 The artifact action major bumps change the underlying Node runtime required on self-hosted runners; GitHub-hosted runners pick this up automatically. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

- webpack: 4 -> 5; webpack-cli: 3 -> 5. - typescript: 3.9 -> 5; tsconfig adds target/module/moduleResolution ('bundler') / skipLibCheck for TS 5 compatibility. - ts-loader: 6 -> 9. - css-loader: 2 -> 7; style-loader: 0.23 -> 4. - copy-webpack-plugin: 6 -> 13. - @svgr/webpack: 5 -> 8. - gettext-extractor: 3.5 -> 3.8. - Drop `file-loader`; replace with webpack 5 native `asset/resource` module type in webpack.config.js. - @types/react / @types/react-dom: bump to latest 16.x patch. - .nvmrc: 14 -> 22. - Regenerate package-lock.json (lockfileVersion 1 -> 3). React / react-dom / styled-components are intentionally left at 16.x / 5.x: bumping React types to 18 surfaces a known incompatibility with @types/styled-components 5, which in turn requires a styled-components 6 migration. That migration is deferred to a dedicated change. Verified `npm run build` produces the expected bundles (wagtail-localize.js, wagtail-localize-component-form.js, CSS files copied). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

The envlist uses the factor `postgres15` (matching the postgres version in CI), but `[gh-actions:env]` mapped `DATABASE=postgres` to the non-existent factor `postgres`. As a result every postgres job in GitHub Actions fell back to tox's default `py` env, which neither pins Django nor Wagtail, instead of running the intended matrix entries. Map `postgres` to `postgres15` so the matrix entries are selected as designed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

`Translation.save_target()` was raising `IntegrityError` on the `(translation_key, locale_id)` unique constraint whenever a snippet being translated contained a `ClusterableModel` child whose own children were also `TranslatableMixin` (e.g. a `Header` snippet with `NavigationLink` children that each have `SubNavigationLink` grandchildren). Wagtail's `CopyForTranslationAction._copy_for_translation` only sets the target locale on the entries it sees in the top-level `child_object_map`. When a direct child is itself a `ClusterableModel`, modelcluster recursively copies the cluster via `copy_cluster()` and the inner `child_object_map` is discarded. The grandchildren therefore keep the source locale; on save, modelcluster commits them with the source `translation_key` paired with the source locale, colliding with the existing source rows. Walk the cluster after `copy_for_translation` returns and re-assign `.locale` on every nested `TranslatableMixin` descendant. The fixup is local to `create_or_update_translation` so it doesn't require changes in Wagtail core. The bug was not visible on the previous test matrix because the `SubNavigationLink` exercise only began to fail on Wagtail 7.3+; the matrix stopped at Wagtail 7.2 before this branch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Django 4.2 LTS reached end of life in April 2026, so the matrix entry is now testing an unsupported runtime. Dropping it also removes the fallout from a regression in wagtail-modeladmin 2.3.0, which only breaks on Django <5.0 (`self.params = request.GET.dict()` followed by `params.lists()`), letting us keep `wagtail-modeladmin>=2.0,<3.0` without pinning. Changes: - pyproject.toml: bump `Django>=4.2` to `Django>=5.1`; drop the `Framework :: Django :: 4.2` classifier. - tox.ini: remove all `django4.2-*` envs from the matrix and the `django4.2: Django>=4.2,<5.0` factor dep. `[testenv:migrations]` now floors at `Django>=5.1,<5.2`. - wagtail_localize/modeladmin/views.py: inline the `DJANGO_VERSION >= (5, 0)` guard in `TranslatableIndexView.get_filters` (always-true under the new floor); drop the now-unused `DJANGO_VERSION` import. - README.md: drop `4.2` from the Django requirements line. - CHANGELOG.md (Unreleased): note the dropped Django 4.2 support and the new minimum Django version. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

nickmoreton · 2026-05-13T13:55:06Z

        super().__init__()


+def _set_locale_on_nested_translatable_children(instance, locale):


Just highlighting:

Upstream Wagtail fix for nested-cluster locale assignment in CopyForTranslationAction — should be filed against wagtail/wagtail so the workaround in models.py can eventually be retired.

In the PR summary above. Could it be related to wagtail/wagtail#14084

@nickmoreton this should be a separate PR please. Has nothing to do with Wagtail 7.4 maintenance work

codecov-commenter · 2026-05-13T14:01:20Z

Codecov Report

❌ Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.04%. Comparing base (8ba01e7) to head (ac77fdf).

Files with missing lines	Patch %	Lines
wagtail_localize/models.py	81.81%	0 Missing and 2 partials ⚠️
wagtail_localize/segments/extract.py	0.00%	0 Missing and 1 partial ⚠️
wagtail_localize/segments/ingest.py	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #921      +/-   ##
==========================================
+ Coverage   93.02%   93.04%   +0.01%     
==========================================
  Files          47       47              
  Lines        4245     4242       -3     
  Branches      551      552       +1     
==========================================
- Hits         3949     3947       -2     
+ Misses        177      176       -1     
  Partials      119      119

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

zerolab · 2026-07-24T13:42:32Z

+### Added
+
+- Wagtail 7.3 and 7.4 (LTS) to the test matrix.
+- Django 5.1 to the test matrix.
+
+### Changed
+
+- Minimum supported Wagtail is now 7.0.
+- Minimum supported Django is now 5.1.
+
+### Fixed
+
+- `Translation.save_target()` no longer raises an `IntegrityError` on the `(translation_key, locale_id)` unique constraint when translating a snippet whose cluster contains nested `TranslatableMixin` grandchildren. Wagtail's `copy_for_translation` only re-locales the top level of the returned cluster, so the fixup is applied here as well.
+
+### Removed
+
+- Support for Wagtail 6.3 (reached end of life on 2026-05-01).
+- Support for Django 4.2 (reached end of life in April 2026).
+- Stale `WAGTAIL_VERSION` and `DJANGO_VERSION` compatibility guards for versions outside the supported range.
+


Please reword in line with other comments on other repositories. tl;dr merge and make it human written

zerolab · 2026-07-24T13:42:57Z

 dependencies = [
-    "Django>=4.2",
-    "Wagtail>=6.3",
+    "Django>=5.1",


Suggested change

"Django>=5.1",

"Django>=5.2",

zerolab · 2026-07-24T13:43:52Z

+    python{3.10,3.11,3.12,3.13}-django5.1-wagtail{7.0,7.2}-postgres15
+    python{3.12,3.13,3.14}-django5.2-wagtail{7.2,7.3,7.4}-postgres15
+    python{3.12,3.13,3.14}-django6.0-wagtail{7.2,7.3,7.4}-postgres15
    # note: we're running a subset of the test with sqlite
-    python3.11-django4.2-wagtail{6.3}-sqlite
-    python3.13-django5.2-wagtail{7.0}-sqlite
-    python3.14-django5.2-wagtail{7.2}-sqlite
-    python3.14-django6.0-wagtail{7.2}-sqlite
+    python3.11-django5.1-wagtail{7.0}-sqlite
+    python3.13-django5.2-wagtail{7.3}-sqlite
+    python3.14-django6.0-wagtail{7.4}-sqlite


Needs to be a bit simpler please.

zerolab · 2026-07-24T13:44:26Z

  - repo: https://github.com/astral-sh/ruff-pre-commit
    # keep in sync with .github/workflows/ruff.yml
-    rev: 'v0.11.8'
+    rev: 'v0.15.12'


now at 0.15.22

nickmoreton and others added 9 commits May 13, 2026 09:39

nickmoreton changed the title ~~Add Wagtail 7.4 LTS support, drop Wagtail 6.3, modernise tooling~~ Wagtail 7.4 LTS maintenance May 13, 2026

nickmoreton commented May 13, 2026

View reviewed changes

nickmoreton marked this pull request as ready for review May 13, 2026 14:03

gasman mentioned this pull request Jun 6, 2026

Compatibility fixes for Wagtail 8.0 #931

Open

zerolab mentioned this pull request Jun 16, 2026

Tests fail to run under some conditions (?) #922

Open

rypptc mentioned this pull request Jun 17, 2026

Fix #922: propagate target locale to all descendants when translating nested snippets #934

Open

zerolab reviewed Jul 24, 2026

View reviewed changes

zerolab requested a review from Stormheg July 24, 2026 14:05

Navigation Menu

Uh oh!

Wagtail 7.4 LTS maintenance - #921

Wagtail 7.4 LTS maintenance#921
nickmoreton wants to merge 9 commits into
wagtail:mainfrom
torchbox-forks:support/wagtail-74-maintenance

nickmoreton commented May 13, 2026 •

edited

Loading

Uh oh!

nickmoreton May 13, 2026

Uh oh!

zerolab Jul 24, 2026

Uh oh!

codecov-commenter commented May 13, 2026 •

edited

Loading

Uh oh!

zerolab Jul 24, 2026

Uh oh!

zerolab Jul 24, 2026

Uh oh!

zerolab Jul 24, 2026

Uh oh!

zerolab Jul 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		super().__init__()


		def _set_locale_on_nested_translatable_children(instance, locale):

Uh oh!

Conversation

nickmoreton commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Deliberately deferred

Test plan

Uh oh!

nickmoreton May 13, 2026

Choose a reason for hiding this comment

Uh oh!

zerolab Jul 24, 2026

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zerolab Jul 24, 2026

Choose a reason for hiding this comment

Uh oh!

zerolab Jul 24, 2026

Choose a reason for hiding this comment

Uh oh!

zerolab Jul 24, 2026

Choose a reason for hiding this comment

Uh oh!

zerolab Jul 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nickmoreton commented May 13, 2026 •

edited

Loading

codecov-commenter commented May 13, 2026 •

edited

Loading