Handle deleted images in translation editor - #939
Open
floze-the-genius wants to merge 1 commit into
Open
Conversation
floze-the-genius
force-pushed
the
agent/handle-deleted-image
branch
from
July 18, 2026 15:02
ea3f487 to
486637a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The chooser parsed every API response and stored it as image metadata. A deleted image returns a non-2xx error payload without
thumbnail, so renderingimageInfo.thumbnail.urlthrew and unmounted the editor.Fixes #769.
Validation
npm test./node_modules/.bin/tsc --noEmitNODE_OPTIONS=--openssl-legacy-provider npm run buildgit diff --checkAI disclosure
I used OpenAI Codex to help investigate the issue, implement the fix, and run validation. I reviewed the resulting code and test coverage before submission.