Skip to content

PC-204: Fix and Improve Term of Subscription Default and Format Date Display #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maryna-Harasko merged 1 commit into from
Oct 27, 2025
Merged

PC-204: Fix and Improve Term of Subscription Default and Format Date Display #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/api/v1/quotes_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def render_not_found
def quote_params_with_defaults
quote_params.merge({
contract_start_date: Date.current,
contract_end_date: Date.current + 1,
contract_end_date: Date.current.next_year - 1.day,
contract_type_id: nil
})
end
Expand Down
4 changes: 3 additions & 1 deletion app/models/quote.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ class Quote < ApplicationRecord
scope :completed, -> { where(step: 'completed') }

def contract_period
"#{contract_start_date} - #{contract_end_date}"
start_date = contract_start_date&.strftime('%m/%d/%Y')
end_date = contract_end_date&.strftime('%m/%d/%Y')
"#{start_date} - #{end_date}"
end

def self.last_unfinished
Expand Down