Add test results ID 635-712 by nishimotz · Pull Request #172 · waic/as_info

nishimotz · 2025-12-03T09:21:15Z

概要

Issue #167 の続きとして、テスト結果を追加

ID 635から674まで（閲覧環境の解答欄なし）
ID 675から712まで（閲覧環境の解答欄あり）

変更内容

テスト結果を追加
マルチラインデータの書式を統一（|-形式）
nullの互換性を改善（空フィールドに統一）
閲覧環境に関する過去データの機械的なバックフィル
Astro 移行を取り込み済み

関連

Issue テスト結果ID 581 から 712 の追加 #167
PR Add tests from as_test (first step for #167) #168（テスト定義の追加）
PR normalize_results_yaml #174 正規化
PR Next.jsからAstroへの移行 #175 Astro
PR ID561以降の視覚閲覧環境のテスト結果のレビューをし、コメントを記載 #183 視覚閲覧環境の結果レビュー

mehm8128

読んでみて、ちょっと気になったところをコメントしてみました。
動作自体は問題なく動作していそうなのと、早めにマージできていた方がASテスト結果のレビューが楽になりそうなので、対応していただけるところは対応していただき次第、マージしてしまうといいかもしれません。

mehm8128 · 2026-02-10T15:18:41Z

+  if (criteria[criterionId]) {
+    return criterionId;
+  }
+  const normalizedId = criterionId.replace(/\s*(\((参考)\)|（参考）)$/u, '');


半角括弧と全角括弧の「参考」を空文字で置換したいだけであれば、グルーピングに使われている括弧が1つ不要かもしれません。

Suggested change

const normalizedId = criterionId.replace(/\s*($(参考)$|（参考）)$/u, '');

const normalizedId = criterionId.replace(/\s*($参考$|（参考）)$/u, '');

mehm8128 · 2026-02-10T15:20:37Z

リファクタできそうという点で、念の為コメントさせていただきます。
contents.lengthで分岐していますが、<th>についているscope属性がrowかrowgroupかという点を除けば他は同じように見えたので、mapでループしている方に統一すれば、そのままlengthが1の場合にも対応できて共通化できそうです（つまり、201～261行目を消して、必要に応じてscope属性を条件分岐するだけで正しく動きそうということです）。

mehm8128 · 2026-02-10T15:33:37Z

-  criteria:
-    - 1.3.1
-    - 4.1.2
+  criteria: []


一部、元々データが入っていたけど空配列になってしまっているcriteriaがあるようなのですが、これは問題ありませんか？

mehm8128 · 2026-02-10T15:40:47Z

+                        {Array.isArray(result.environment_type)
+                          ? result.environment_type.map((item: string) => (
+                            <li style={listItemStyle}>{item}</li>
+                          ))
+                          : result.environment_type && (
+                            <li style={listItemStyle}>{result.environment_type}</li>
+                          )}


将来的にでも、resultsを取得するタイミングでenvironment_typeを配列に変換しておけると、1つの場合も複数の場合も空の場合も全部string[]型で扱うことができて楽かもしれません。

ID 561以降のテスト結果で、閲覧環境が空欄のところを補完

ID561以降の視覚閲覧環境のテスト結果のレビューをし、コメントを記載

…yaml

…lize environment_type - utils.ts: remove unnecessary capture group in getCriterionLookupId regex (comment 1) - results/[id].astro: unify contents.length branch into single map with scope row/rowgroup (comment 2) - results/[id].astro: normalize environment_type to string[] when loading results (comment 4)

nishimotz · 2026-02-16T09:34:28Z

いただいたレビューの提案を反映しました。

mehm8128 · 2026-02-16T13:06:20Z

ありがとうございます、問題ないと思いました。

… results.yaml for clarity

…fo into issue-167-add-results-581-674

… and reviewer comments. Changed environment_type from 音声閲覧環境 to 視覚閲覧環境 in results.yaml and added relevant reviewer comments for clarity.

…環境 and add reviewer comments for results IDs 707-712.

…, and 707-712, and enhance reviewer comments with proper formatting.

nishimotz temporarily deployed to as-info-next December 3, 2025 09:21 — with GitHub Actions Inactive

nishimotz self-assigned this Dec 3, 2025

nishimotz temporarily deployed to as-info-next December 3, 2025 10:07 — with GitHub Actions Inactive

nishimotz temporarily deployed to as-info-next December 10, 2025 09:46 — with GitHub Actions Inactive

nishimotz temporarily deployed to as-info-next December 10, 2025 11:12 — with GitHub Actions Inactive

nishimotz changed the title ~~Add test results ID 581-674 and unify multiline data format (Issue #167)~~ Add test results ID 635-674 and unify multiline data format (Issue #167) Dec 10, 2025

nishimotz mentioned this pull request Jan 7, 2026

normalize_results_yaml #174

Merged

nishimotz temporarily deployed to as-info-next January 7, 2026 09:27 — with GitHub Actions Inactive

nishimotz added 4 commits January 14, 2026 10:38

id 674 までのデータを追加。マルチラインデータの書式を統一。

87501ce

tests.yaml更新

3b4edb2

リテラルブロック形式に戻す

bfa4b72

空行と複数行をさらに正規化

5900ef7

nishimotz force-pushed the issue-167-add-results-581-674 branch from 11b44e6 to 5900ef7 Compare January 14, 2026 01:38

nishimotz temporarily deployed to as-info-next January 14, 2026 01:38 — with GitHub Actions Inactive

Add environment_type field and update results layout

44d81ab

nishimotz temporarily deployed to as-info-next January 14, 2026 04:11 — with GitHub Actions Inactive

nishimotz changed the title ~~Add test results ID 635-674 and unify multiline data format (Issue #167)~~ Add test results ID 635- Jan 14, 2026

nishimotz mentioned this pull request Jan 14, 2026

テスト結果ID 581 から 712 の追加 #167

Closed

Refactor code structure for improved readability and maintainability

d2dd088

nishimotz had a problem deploying to as-info-next January 14, 2026 05:24 — with GitHub Actions Failure

Add getCriterionLookupId function and update results display logic

8adaed2

nishimotz temporarily deployed to as-info-next January 14, 2026 05:32 — with GitHub Actions Inactive

Handle reference criteria ids in checkdata

03a4641

nishimotz temporarily deployed to as-info-next January 14, 2026 05:34 — with GitHub Actions Inactive

Add getLinkBase function and update link handling across pages

5391b25

nishimotz temporarily deployed to as-info-next January 14, 2026 05:46 — with GitHub Actions Inactive

mehm8128 reviewed Feb 10, 2026

View reviewed changes

mehm8128 and others added 3 commits February 11, 2026 17:07

閲覧環境が埋まっていないところを補完

a8e3ed9

Merge pull request #182 from waic/complement-missing-environment-type

8f038c7

ID 561以降のテスト結果で、閲覧環境が空欄のところを補完

review: 視覚閲覧環境のテスト結果のレビューをし、コメントを記載

cfac89b

mehm8128 mentioned this pull request Feb 14, 2026

ID561以降の視覚閲覧環境のテスト結果のレビューをし、コメントを記載 #183

Merged

nishimotz added 3 commits February 16, 2026 17:53

Merge pull request #183 from waic/review/sight-environment

e4032e3

ID561以降の視覚閲覧環境のテスト結果のレビューをし、コメントを記載

Merge origin/master: resolve conflicts in Navigation.astro and tests.…

d9f8815

…yaml

nishimotz temporarily deployed to as-info-next February 16, 2026 09:17 — with GitHub Actions Inactive

typo 修正

b090e10

nishimotz temporarily deployed to as-info-next February 16, 2026 09:24 — with GitHub Actions Inactive

Merge branch 'master' into issue-167-add-results-581-674

67aeb27

nishimotz temporarily deployed to as-info-next February 16, 2026 09:26 — with GitHub Actions Inactive

Merge branch 'master' into issue-167-add-results-581-674

5792648

nishimotz temporarily deployed to as-info-next February 16, 2026 09:31 — with GitHub Actions Inactive

mehm8128 approved these changes Feb 16, 2026

View reviewed changes

nishimotz added 2 commits March 4, 2026 17:15

Update .gitignore to exclude .xlsx files and add reviewer comments in…

b0f5fdf

… results.yaml for clarity

Merge branch 'issue-167-add-results-581-674' of github.com:waic/as_in…

9d9de1b

…fo into issue-167-add-results-581-674

nishimotz temporarily deployed to as-info-next March 4, 2026 08:16 — with GitHub Actions Inactive

Update review.md and results.yaml to reflect environment type changes…

3d2817f

… and reviewer comments. Changed environment_type from 音声閲覧環境 to 視覚閲覧環境 in results.yaml and added relevant reviewer comments for clarity.

nishimotz temporarily deployed to as-info-next March 4, 2026 08:48 — with GitHub Actions Inactive

Update review.md and results.yaml to correct environment_type to 視覚閲覧…

4adc727

…環境 and add reviewer comments for results IDs 707-712.

nishimotz temporarily deployed to as-info-next March 4, 2026 09:08 — with GitHub Actions Inactive

Update review.md to correct environment_type for results IDs 641, 703…

07cc53b

…, and 707-712, and enhance reviewer comments with proper formatting.

nishimotz temporarily deployed to as-info-next March 4, 2026 09:09 — with GitHub Actions Inactive

nishimotz changed the title ~~Add test results ID 635-~~ Add test results ID 635-712 Mar 11, 2026

nishimotz merged commit 291de46 into master Mar 11, 2026
5 checks passed

nishimotz deleted the issue-167-add-results-581-674 branch March 11, 2026 05:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add test results ID 635-712#172

Add test results ID 635-712#172
nishimotz merged 23 commits into
masterfrom
issue-167-add-results-581-674

nishimotz commented Dec 3, 2025 •

edited

Loading

Uh oh!

mehm8128 left a comment

Uh oh!

mehm8128 Feb 10, 2026

Uh oh!

mehm8128 Feb 10, 2026

Uh oh!

mehm8128 Feb 10, 2026

Uh oh!

mehm8128 Feb 10, 2026

Uh oh!

nishimotz commented Feb 16, 2026

Uh oh!

mehm8128 commented Feb 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	const normalizedId = criterionId.replace(/\s*(\((参考)\)\|（参考）)$/u, '');
	const normalizedId = criterionId.replace(/\s*(\(参考\)\|（参考）)$/u, '');

Conversation

nishimotz commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

概要

変更内容

関連

Uh oh!

mehm8128 left a comment

Choose a reason for hiding this comment

Uh oh!

mehm8128 Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

mehm8128 Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

mehm8128 Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

mehm8128 Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

nishimotz commented Feb 16, 2026

Uh oh!

mehm8128 commented Feb 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nishimotz commented Dec 3, 2025 •

edited

Loading