fix: v3-alpha wails3 cli installation path#4597
Conversation
WalkthroughReplaced two occurrences of the Go install module path from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dosubot
Bot
added
size:XS
|
Related Documentation Checked 1 published document(s). No updates required. You have 2 draft document(s). Publish docs to keep them always up-to-date How did I do? Any feedback? |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/nightly-release-v3.yml(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (3)
.github/workflows/nightly-release-v3.yml (3)
486-487: Correct install path updated to cmd/wails3.Matches v3 module path and resolves #4596/PR objective. Good catch in the DRY RUN preview.
520-521: Live release notes fixed as well.The install snippet now correctly points to cmd/wails3. Keeps DRY RUN and LIVE outputs consistent.
729-729: Trailing newline added.Minor hygiene improvement; avoids “No newline at end of file” diffs later.
| echo "go install github.com/wailsapp/wails/v3/cmd/wails3@${{ steps.release.outputs.tag }}" | ||
| echo "\`\`\`" |
There was a problem hiding this comment.
🧩 Analysis chain
Sweep for any remaining cmd/wails occurrences.
To prevent regressions in other docs/workflows, run a quick repo-wide check.
Also applies to: 520-521
🏁 Script executed:
#!/bin/bash
# Find any stale v3 install snippets still pointing at cmd/wails@
rg -nP -C2 --hidden -g '!**/vendor/**' $'go\\s+install\\s+github\\.com/wailsapp/wails/v3/cmd/wails@'
# Show all current wails3 install snippets for confirmation
rg -nP -C2 --hidden -g '!**/vendor/**' $'go\\s+install\\s+github\\.com/wailsapp/wails/v3/cmd/wails3@'Length of output: 297
🏁 Script executed:
#!/bin/bash
# Find any stale v3 install snippets still pointing at cmd/wails@
rg -nP -C2 --ignore-dir vendor 'go\s+install\s+github\.com/wailsapp/wails/v3/cmd/wails@' .
# Show all current wails3 install snippets for confirmation
rg -nP -C2 --ignore-dir vendor 'go\s+install\s+github\.com/wailsapp/wails/v3/cmd/wails3@' .Length of output: 885
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Searching for old 'cmd/wails@' go install lines..."
grep -RIn --binary-files=without-match --exclude-dir=vendor -E 'go[[:space:]]+install[[:space:]]+github\.com/wailsapp/wails/v3/cmd/wails@' . || true
echo "Searching for 'cmd/wails3@' go install lines..."
grep -RIn --binary-files=without-match --exclude-dir=vendor -E 'go[[:space:]]+install[[:space:]]+github\.com/wailsapp/wails/v3/cmd/wails3@' . || true
echo "Searching for any occurrences of 'cmd/wails'..."
grep -RIn --binary-files=without-match --exclude-dir=vendor -F 'cmd/wails' . || true
echo "Showing .github/workflows/nightly-release-v3.yml lines 470-530 (if present)..."
if [ -f ".github/workflows/nightly-release-v3.yml" ]; then
sed -n '470,530p' .github/workflows/nightly-release-v3.yml || true
else
echo "file not found: .github/workflows/nightly-release-v3.yml"
fiLength of output: 102199
Sweep for remaining cmd/wails usages — fix v3/internal reference
nightly-release-v3.yml already uses cmd/wails3 (lines 486, 520). v3/internal/commands/update_cli.go:164 still runs go install github.com/wailsapp/wails/v3/cmd/wails@… — change to github.com/wailsapp/wails/v3/cmd/wails3@… or confirm it's intentional. Other matches are v2 docs/translations and can remain.
🤖 Prompt for AI Agents
In v3/internal/commands/update_cli.go around line 164, the code still runs "go
install github.com/wailsapp/wails/v3/cmd/wails@…" which mismatches the rest of
the repo using cmd/wails3; update the import string to
"github.com/wailsapp/wails/v3/cmd/wails3@${tagOrVersion}" (or the equivalent
variable used there), i.e., replace "cmd/wails" with "cmd/wails3" so the
installed binary matches the v3 workflow, and run tests/CI to confirm no other
references need changing.
github-actions
Bot
added
Documentation
|
* fix: v3-alpha wails3 cli installation path * Update Changelog --------- Co-authored-by: Lea Anthony <lea.anthony@gmail.com>
2 participants
Description
Fixes the wails3 binary installation module path in pre-release note.
Fixes #4596
Type of change
Please select the option that is relevant.
Summary by CodeRabbit