-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[Snyk] Fix for 2 vulnerabilities #4992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,8 +15,8 @@ | |
| }, | ||
| "dependencies": { | ||
| "@crowdin/crowdin-api-client": "^1.33.1", | ||
| "@docusaurus/core": "^3.9.0", | ||
| "@docusaurus/preset-classic": "^3.9.0", | ||
| "@docusaurus/core": "^3.8.0", | ||
| "@docusaurus/preset-classic": "^3.8.0", | ||
|
Comment on lines
+18
to
+19
|
||
| "@docusaurus/theme-search-algolia": "^3.9.0", | ||
|
||
| "@mdx-js/react": "^3.0.0", | ||
| "@swc/core": "^1.6.0", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description states this fixes vulnerabilities SNYK-JS-AXIOS-15252993 (Prototype Pollution in axios) and SNYK-JS-AJV-15274295 (ReDoS in ajv), but downgrading Docusaurus packages from 3.9.0 to 3.8.0 would not fix these vulnerabilities if they exist in the current version. Security fixes require upgrading to patched versions, not downgrading. The PR description metadata indicates this should upgrade dependencies to fix vulnerabilities, but the actual changes do the opposite. This suggests either the PR was generated incorrectly by Snyk, or the intended changes were to upgrade to a newer version (possibly 3.10.0 or later) and were incorrectly applied as downgrades.