fix(v2): copy frontend build output to embed target when frontend:dir is custom#5178
Closed
leaanthony wants to merge 2 commits into
Closed
fix(v2): copy frontend build output to embed target when frontend:dir is custom#5178leaanthony wants to merge 2 commits into
leaanthony wants to merge 2 commits into
Conversation
… is custom When frontend:dir in wails.json is set to a non-default directory (e.g. "jsfrontend" instead of "frontend"), the Go embed directive //go:embed all:frontend/dist still looks at frontend/dist, but the built assets are in the custom directory's dist folder. This causes the compiled binary to have no frontend assets. After BuildFrontend completes, if the frontend dir differs from the default "frontend", this change copies the built dist contents to the embed target directory so the Go compiler can find them. Only applies when the custom frontend directory is within the project tree. External frontend directories (../foo) are not supported due to Go embed's path restrictions. Fixes #5034
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
Author
|
Closing in favor of #5251 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
frontend:dirinwails.jsonis set to a non-default directory (e.g."jsfrontend"instead of"frontend"), the//go:embed all:frontend/distdirective inmain.gostill looks atfrontend/dist. The built assets end up injsfrontend/dist, so the compiled binary has no frontend assets — just the gitkeep placeholder.This PR adds a
syncFrontendToEmbedTarget()function that runs afterBuildFrontend. When the frontend dir differs from the default, it copies the built dist contents to the embed target directory (determined via static analysis of//go:embeddirectives).Limitations:
../frontend) cannot be supported due to Go's embed path restrictions (no..allowed)//go:embeddirective to match theirfrontend:dirTest case:
wails init -n clientfrontendtojsfrontend"frontend:dir": "./jsfrontend"towails.jsonwails build→ app now works correctlyFixes #5034