fix(w32): pass HMENU to DestroyMenu syscall#5228

Merged

leaanthony merged 22 commits into

wailsapp:masterfrom

johnmaguire:fix/windows-systray-setmenu-crashes

May 1, 2026

Commits on May 1, 2026

fix(w32): pass HMENU to DestroyMenu syscall

johnmaguire
and
claude
committed
fix(windows/systray): release previous menu in updateMenu; drop duplicate Update

johnmaguire
and
claude
committed
fix(windows/popupmenu): destroy old HMENU and reset stale maps in Update

johnmaguire
and
claude
committed
fix(windows/popupmenu): soft-fail AppendMenu and SetMenuIcons errors

johnmaguire
and
claude
committed
fix(windows/popupmenu,menu,menuitem): release HBITMAP handles on menu destroy

johnmaguire
and
claude
committed
test(examples): add systray-stress regression harness

johnmaguire
and
claude
committed
test(w32): add regression tests for DestroyMenu syscall signature

johnmaguire
and
claude
committed
test(examples): add mutate mode exercising runtime SetBitmap leak

johnmaguire
and
claude
committed
fix(windows/menu,popupmenu): release runtime SetBitmap HBITMAPs on destroy

johnmaguire
and
claude
committed
Update changelog
johnmaguire
committed
fix(windows/menu): reset menuMapping and currentMenuID in windowsMenu.update

johnmaguire
and
claude
committed
fix(windows/menu): log and abort on AppendMenu/SetMenuIcons failure in processMenu

johnmaguire
and
claude
committed
test(examples): capture runtime_ms for every exit branch in systray-stress

johnmaguire
and
claude
committed
docs(examples): reframe mutate-mode comments as regression guard

johnmaguire
and
claude
committed
fix(windows/menu,popupmenu): stage rebuild locally and propagate build errors

johnmaguire
and
claude
committed
test(examples): rename logJSON to logEvent in systray-stress

johnmaguire
and
claude
committed
test(examples): drop dead icons import from systray-stress

johnmaguire
and
claude
committed
fix(windows/menu,popupmenu): hoist runtime SetBitmap handles before build

johnmaguire
and
claude
committed
test(windows/menu): regression-guard runtime SetBitmap cleanup

johnmaguire
and
claude
committed
test(windows/menu): fail loudly on GetGuiResources probe failure

johnmaguire
and
claude
committed
test(windows/menu): regression-guard Win32Menu churn teardown

johnmaguire
and
claude
committed
test(windows/menu): drop GDI-probe unit regression tests

johnmaguire
and
claude
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(w32): pass HMENU to DestroyMenu syscall#5228

fix(w32): pass HMENU to DestroyMenu syscall#5228
leaanthony merged 22 commits into
wailsapp:masterfrom
johnmaguire:fix/windows-systray-setmenu-crashes

Commits on May 1, 2026

fix(w32): pass HMENU to DestroyMenu syscall

fix(windows/systray): release previous menu in updateMenu; drop duplicate Update

fix(windows/popupmenu): destroy old HMENU and reset stale maps in Update

fix(windows/popupmenu): soft-fail AppendMenu and SetMenuIcons errors

fix(windows/popupmenu,menu,menuitem): release HBITMAP handles on menu destroy

test(examples): add systray-stress regression harness

test(w32): add regression tests for DestroyMenu syscall signature

test(examples): add mutate mode exercising runtime SetBitmap leak

fix(windows/menu,popupmenu): release runtime SetBitmap HBITMAPs on destroy

Update changelog

fix(windows/menu): reset menuMapping and currentMenuID in windowsMenu.update

fix(windows/menu): log and abort on AppendMenu/SetMenuIcons failure in processMenu

test(examples): capture runtime_ms for every exit branch in systray-stress

docs(examples): reframe mutate-mode comments as regression guard

fix(windows/menu,popupmenu): stage rebuild locally and propagate build errors

test(examples): rename logJSON to logEvent in systray-stress

test(examples): drop dead icons import from systray-stress

fix(windows/menu,popupmenu): hoist runtime SetBitmap handles before build

test(windows/menu): regression-guard runtime SetBitmap cleanup

test(windows/menu): fail loudly on GetGuiResources probe failure

test(windows/menu): regression-guard Win32Menu churn teardown

test(windows/menu): drop GDI-probe unit regression tests