chore(workflows): pre-merge changelog-trigger permission from master#5270
Conversation
Adopts two changes that already exist on master so the eventual v3-alpha → master merge has fewer conflicts to hand-resolve: - auto-label-issues.yml: switch the PR trigger from `pull_request` to `pull_request_target` so the workflow can label PRs from forks (security hardening already in place on master). - unreleased-changelog-trigger.yml: add the `actions: write` permission needed by the trigger step (already in place on master). No behaviour change for v3-alpha-only paths. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 3/8 reviews remaining, refill in 35 minutes and 21 seconds.Comment |
I had the direction backwards in the previous commit on this branch. v3-alpha already uses pull_request_target (the security-hardened trigger that lets the workflow label PRs from forks); master is the one still on the older pull_request. The fix to auto-label-issues belongs on master, not on v3-alpha. Reverting that part of this PR so v3-alpha keeps its current behaviour. The unreleased-changelog permission update remains. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Syncs v3-alpha workflow permissions with master to reduce merge conflicts and ensure the unreleased-changelog trigger can dispatch the nightly release workflow successfully.
Changes:
- Adds
actions: writepermission to thetrigger-releasejob so it can callactions.createWorkflowDispatch.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ws): pre-merge changelog-trigger permission from master
Summary
Adopts a workflow change that already exists on
masterso the eventualv3-alpha → mastermerge has one fewer conflict to hand-resolve..github/workflows/unreleased-changelog-trigger.yml— add theactions: writepermission needed by the trigger step (already in place on master).Erratum
An earlier commit on this branch also touched
auto-label-issues.ymlin the wrong direction (master's olderpull_requestaccidentally copied over v3-alpha'spull_request_target); that has been reverted in commitbebdcf77. The correct fix for that file goes onto master, not v3-alpha — see the companion PR for master-side workflow pre-merges.Test plan
v3-alphais the singleactions: writeline inunreleased-changelog-trigger.yml.🤖 Generated with Claude Code
Summary by CodeRabbit