Skip to content

chore(workflows): pre-merge changelog-trigger permission from master#5270

Merged
leaanthony merged 2 commits into
v3-alphafrom
chore/workflow-pre-merge-v3
Apr 29, 2026
Merged

chore(workflows): pre-merge changelog-trigger permission from master#5270
leaanthony merged 2 commits into
v3-alphafrom
chore/workflow-pre-merge-v3

Conversation

@leaanthony

@leaanthony leaanthony commented Apr 29, 2026

Copy link
Copy Markdown
Member

Summary

Adopts a workflow change that already exists on master so the eventual v3-alpha → master merge has one fewer conflict to hand-resolve.

  • .github/workflows/unreleased-changelog-trigger.yml — add the actions: write permission needed by the trigger step (already in place on master).

Erratum

An earlier commit on this branch also touched auto-label-issues.yml in the wrong direction (master's older pull_request accidentally copied over v3-alpha's pull_request_target); that has been reverted in commit bebdcf77. The correct fix for that file goes onto master, not v3-alpha — see the companion PR for master-side workflow pre-merges.

Test plan

  • CI green
  • Net diff vs v3-alpha is the single actions: write line in unreleased-changelog-trigger.yml.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflow permissions to support workflow dispatch functionality during release processes.

Adopts two changes that already exist on master so the eventual
v3-alpha → master merge has fewer conflicts to hand-resolve:

- auto-label-issues.yml: switch the PR trigger from `pull_request` to
  `pull_request_target` so the workflow can label PRs from forks
  (security hardening already in place on master).
- unreleased-changelog-trigger.yml: add the `actions: write` permission
  needed by the trigger step (already in place on master).

No behaviour change for v3-alpha-only paths.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 29, 2026 11:32
@coderabbitai

coderabbitai Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 284731d0-274d-41ee-a90f-9fa7c1b41c3f

📥 Commits

Reviewing files that changed from the base of the PR and between 15abd79 and bebdcf7.

📒 Files selected for processing (1)
  • .github/workflows/unreleased-changelog-trigger.yml

Walkthrough

The trigger-release job in the unreleased-changelog-trigger workflow is granted actions: write permission in addition to its existing contents: read permission, enabling it to dispatch workflows under the GitHub token used during release triggering.

Changes

Cohort / File(s) Summary
Workflow Permissions
.github/workflows/unreleased-changelog-trigger.yml
Added actions: write permission to the trigger-release job to enable workflow dispatch capabilities during release triggering.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A single line, so small yet grand,
Actions write now at hand!
Release the workflows, set them free,
With permissions new, oh what will be! ✨🚀

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: granting workflows pre-merge permissions from master, specifically the actions: write permission for changelog-trigger.
Description check ✅ Passed The PR description clearly explains the purpose and changes, but does not follow the repository's required template structure with Type of change and Testing checkboxes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/workflow-pre-merge-v3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 3/8 reviews remaining, refill in 35 minutes and 21 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

I had the direction backwards in the previous commit on this branch.
v3-alpha already uses pull_request_target (the security-hardened
trigger that lets the workflow label PRs from forks); master is the
one still on the older pull_request. The fix to auto-label-issues
belongs on master, not on v3-alpha. Reverting that part of this PR
so v3-alpha keeps its current behaviour. The unreleased-changelog
permission update remains.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@leaanthony leaanthony changed the title chore(workflows): pre-merge auto-label and changelog-trigger from master chore(workflows): pre-merge changelog-trigger permission from master Apr 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Syncs v3-alpha workflow permissions with master to reduce merge conflicts and ensure the unreleased-changelog trigger can dispatch the nightly release workflow successfully.

Changes:

  • Adds actions: write permission to the trigger-release job so it can call actions.createWorkflowDispatch.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@leaanthony leaanthony merged commit 69a7e19 into v3-alpha Apr 29, 2026
48 of 49 checks passed
@leaanthony leaanthony deleted the chore/workflow-pre-merge-v3 branch April 29, 2026 11:57
@leaanthony leaanthony mentioned this pull request Apr 29, 2026
3 tasks
pull Bot pushed a commit to c3b2a7/wails that referenced this pull request Apr 29, 2026
…ws): pre-merge changelog-trigger permission from master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants