Skip to content

ci(docs): pin docs build to Node 22.12.0 for Astro 6.4+#5696

Merged
taliesin-ai merged 1 commit into
masterfrom
ci/docs-node-22
Jun 29, 2026
Merged

ci(docs): pin docs build to Node 22.12.0 for Astro 6.4+#5696
taliesin-ai merged 1 commit into
masterfrom
ci/docs-node-22

Conversation

@taliesin-ai

@taliesin-ai taliesin-ai commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Why

Astro 6.4 dropped Node 20 support — its engines.node is now >=22.12.0 (6.0.0 allowed ^20.19.1 || >=22.12.0). The Cloudflare Pages wails-v3-site docs build has no Node pin, so it runs Cloudflare's default (<22.12.0) and fails the engine check the moment astro resolves to 6.4.x. This is exactly why #5641 (which bumps the docs lockfile to astro 6.4.8) fails its Cloudflare check.

Change

Pin the docs/ build root to Node 22.12.0 via .nvmrc + .node-version (Cloudflare Pages reads either from the project root directory).

Follow-up (dashboard — can't be done in-repo)

If the Cloudflare Pages project has a NODE_VERSION environment variable set in the dashboard, it overrides these files — it should be set to 22.12.0 (or removed so the files take effect). Once this lands, updating #5641's branch should make its Cloudflare build pass.

Summary by CodeRabbit

  • Chores
    • Updated the project’s Node.js version settings to 22.12.0 for the documentation environment.

Astro 6.4 dropped Node 20 support (engines.node '>=22.12.0'), so the
Cloudflare Pages 'wails-v3-site' docs build fails once astro resolves to
6.4.x. Pin the docs build root to Node 22.12.0 so it (and future astro
bumps, e.g. #5641) build cleanly.
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c84a35d8-b16f-4313-b656-f478fcffaca8

📥 Commits

Reviewing files that changed from the base of the PR and between 312e8d0 and 29fb423.

📒 Files selected for processing (2)
  • docs/.node-version
  • docs/.nvmrc

Walkthrough

Both docs/.node-version and docs/.nvmrc are updated to pin the Node.js runtime version to 22.12.0.

Changes

Node.js Version Pin

Layer / File(s) Summary
Node.js version files
docs/.node-version, docs/.nvmrc
Both files are set to 22.12.0 to pin the Node.js runtime for the docs environment.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minutes

Possibly related PRs

Poem

🐇 A version is pinned, neat and true,
Node twenty-two, twelve-point-oh new!
The docs hop along on fresh runtime ground,
No mismatched engines to be found.
Carrots for all — the config is sound! 🥕

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change well, but it omits most required template sections like testing, type of change, and checklist items. Add the missing template sections: issue link, type of change, testing details, test configuration, and checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the docs Node version pin and the Astro 6.4 context, matching the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/docs-node-22

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@taliesin-ai taliesin-ai enabled auto-merge (squash) June 29, 2026 07:41
@taliesin-ai taliesin-ai merged commit dacfa36 into master Jun 29, 2026
18 checks passed
@taliesin-ai taliesin-ai deleted the ci/docs-node-22 branch June 29, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants