ci(docs): pin docs build to Node 22.12.0 for Astro 6.4+#5696
Merged
Conversation
Astro 6.4 dropped Node 20 support (engines.node '>=22.12.0'), so the Cloudflare Pages 'wails-v3-site' docs build fails once astro resolves to 6.4.x. Pin the docs build root to Node 22.12.0 so it (and future astro bumps, e.g. #5641) build cleanly.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughBoth ChangesNode.js Version Pin
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
leaanthony
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Astro 6.4 dropped Node 20 support — its
engines.nodeis now>=22.12.0(6.0.0 allowed^20.19.1 || >=22.12.0). The Cloudflare Pages wails-v3-site docs build has no Node pin, so it runs Cloudflare's default (<22.12.0) and fails the engine check the momentastroresolves to 6.4.x. This is exactly why #5641 (which bumps the docs lockfile to astro 6.4.8) fails its Cloudflare check.Change
Pin the
docs/build root to Node 22.12.0 via.nvmrc+.node-version(Cloudflare Pages reads either from the project root directory).Follow-up (dashboard — can't be done in-repo)
If the Cloudflare Pages project has a
NODE_VERSIONenvironment variable set in the dashboard, it overrides these files — it should be set to22.12.0(or removed so the files take effect). Once this lands, updating #5641's branch should make its Cloudflare build pass.Summary by CodeRabbit