Skip to content

feat!: use yamux instead of mplex #2325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

feat!: use yamux instead of mplex #2325

wants to merge 4 commits into from

Conversation

weboko
Copy link
Collaborator

@weboko weboko commented Mar 26, 2025

Problem / Description

Consensus is to use yamux

Solution

Use it

Notes


Checklist

  • Code changes are covered by unit tests.
  • Code changes are covered by e2e tests, if applicable.
  • Dogfooding has been performed, if feasible.
  • A test version has been published, if required.
  • All CI checks pass successfully.

Copy link

github-actions bot commented Mar 26, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 61.97 KB (+0.05% 🔺) 1.3 s (+0.05% 🔺) 709 ms (+15.22% 🔺) 2 s
Waku Simple Light Node 115.99 KB (+1.79% 🔺) 2.4 s (+1.79% 🔺) 1.2 s (+22.97% 🔺) 3.6 s
ECIES encryption 23.06 KB (+0.56% 🔺) 462 ms (+0.56% 🔺) 330 ms (-50.82% 🔽) 791 ms
Symmetric encryption 22.49 KB (+0.53% 🔺) 450 ms (+0.53% 🔺) 526 ms (+28.9% 🔺) 976 ms
DNS discovery 50.67 KB (+0.73% 🔺) 1.1 s (+0.73% 🔺) 1.1 s (+21.58% 🔺) 2.1 s
Peer Exchange discovery 51.14 KB (+0.83% 🔺) 1.1 s (+0.83% 🔺) 840 ms (+45.52% 🔺) 1.9 s
Local Peer Cache Discovery 44.43 KB (+1.43% 🔺) 889 ms (+1.43% 🔺) 812 ms (+26.81% 🔺) 1.7 s
Privacy preserving protocols 52.87 KB (+0.03% 🔺) 1.1 s (+0.03% 🔺) 713 ms (+43.34% 🔺) 1.8 s
Waku Filter 54.79 KB (-0.09% 🔽) 1.1 s (-0.09% 🔽) 804 ms (+40.23% 🔺) 1.9 s
Waku LightPush 52.25 KB (+0.03% 🔺) 1.1 s (+0.03% 🔺) 945 ms (+87.81% 🔺) 2 s
History retrieval protocols 52.45 KB (+0.06% 🔺) 1.1 s (+0.06% 🔺) 800 ms (+38.06% 🔺) 1.9 s
Deterministic Message Hashing 7.32 KB (-0.23% 🔽) 147 ms (-0.23% 🔽) 87 ms (-60.05% 🔽) 233 ms

@weboko weboko mentioned this pull request Mar 27, 2025
6 tasks
@weboko
Copy link
Collaborator Author

weboko commented Mar 27, 2025

Prev PR - #1894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: use yamux instead of mplex
1 participant