-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use counter instead of gauge for metrics that only increase over time #3355
base: master
Are you sure you want to change the base?
Conversation
You can find the image built from this PR at
Built from 7c17b77 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the grafana panels work without change upon this?
unless they are using some special property assuming gauge they should work the same. |
I am not able to understand why lint is failing. |
I think counters in prometheus will be postfixed by |
Description
Noticed that gauge is being used for metrics that increase over time like number of msgs received/pushed etc.
Aligning them as per definitions https://prometheus.io/docs/concepts/metric_types/