Skip to content

fix: Update the upload-artifact from v3 to v4 in pre-release.yml #3363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

Ivansete-status
Copy link
Collaborator

@Ivansete-status Ivansete-status commented Apr 8, 2025

Description

This PR aims to avoid the following issue in pre-release gh action:

image

The fix suggestion is inspired by the hint given in the link https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ (see above picture.) In that link, we have the following recommendation:

image

Issue

closes:

Copy link

github-actions bot commented Apr 8, 2025

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3363

Built from 7416f1a

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, Thanks!!! 👍

@Ivansete-status Ivansete-status merged commit b27ebbe into master Apr 9, 2025
13 of 16 checks passed
@Ivansete-status Ivansete-status deleted the update-gh-upload-artifact branch April 9, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants