feat: enhance Sync logs and metrics #3370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SionoiS
changed the title
|
You can find the image built from this PR at Built from 8b2c1f8 |
SionoiS
changed the title
Ivansete-status
approved these changes
Apr 16, 2025
| return err("connection write error: " & writeRes.error.msg) | ||
| await connection.close() | ||
| return err( | ||
| "remote " & $connection.peerId & " connection write error: " & writeRes.error.msg |
There was a problem hiding this comment.
Just to differentiate it a little from the other:
Suggested change
| "remote " & $connection.peerId & " connection write error: " & writeRes.error.msg | |
| "remote " & $connection.peerId & " connection write error initiate: " & writeRes.error.msg |
| @@ -217,7 +229,7 @@ proc storeSynchronization*( | |||
| let connOpt = await self.peerManager.dialPeer(peer, WakuReconciliationCodec) | |||
|
|
|||
| let conn: Connection = connOpt.valueOr: | |||
| return err("cannot establish sync connection") | |||
| return err("fail to dial remote " & $peer.peerId) | |||
There was a problem hiding this comment.
Maybe?
Suggested change
| return err("fail to dial remote " & $peer.peerId) | |
| return err("fail to dial remote " & $peer.peerId & " store sync conn error: " & $error) |
There was a problem hiding this comment.
It's an Option there's no error to log sadly.
| @@ -69,7 +70,7 @@ proc openConnection( | |||
| let connOpt = await self.peerManager.dialPeer(peerId, WakuTransferCodec) | |||
|
|
|||
| let conn: Connection = connOpt.valueOr: | |||
| return err("Cannot establish transfer connection") | |||
| return err("fail to dial remote " & $peerId) | |||
There was a problem hiding this comment.
Maybe :)?
Suggested change
| return err("fail to dial remote " & $peerId) | |
| return err("fail to dial remote " & $peerId & " open conn error: " & $error) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added the remote peer id to most logs so that it's easier to know which connection failed.
Also, added metrics for differences found.