feat: split runtime/build server entries to exclude static routes from runtime bundle by TiwariLokesh · Pull Request #1974 · wakujs/waku

TiwariLokesh · 2026-03-01T08:43:16Z

Summary

This PR addresses #1912 by introducing a proper architectural separation between runtime and build server entries.

Instead of pruning static route modules after build, this change prevents fully static routes from entering the runtime module graph in the first place.

Motivation

Currently, routes marked with render: "static" are still bundled into the runtime server output even though they are only needed during SSG. This increases the production bundle size (e.g. large OpenGraph libraries, WASM blobs) and can cause deployment size constraints in environments like Cloudflare Workers.

The previous workaround relied on post-build pruning. This PR removes that approach and replaces it with a cleaner graph-level separation.

What Changed

1. Runtime / Build Entry Split

Introduced two separate virtual server entries:

virtual:vite-rsc-waku/server-entry-runtime
virtual:vite-rsc-waku/server-entry-build

Runtime and build now generate independent module graphs.

2. Managed Mode Runtime Exclusion

In managed fsRouter mode:

Runtime entry excludes fully static page modules using import.meta.glob negative patterns.
Build entry keeps the full route graph to allow SSG to function normally.

3. Mode-Aware Router Resolution

getConfigs({ mode }) is now propagated through define-router.
Runtime paths resolve configs using mode: "runtime".
Build paths resolve configs using mode: "build".

4. Removed Post-Build Pruning

build-static-files.ts no longer performs file-level pruning.
Static route exclusion is now handled at graph-construction time instead of cleanup time.

Result

Static routes are still generated during SSG.
Static-only route modules are no longer included in the runtime server bundle (in managed mode).
No public API changes.
Backward compatible.
Cleaner architecture.

Notes

Static route detection in managed mode is heuristic-based (literal render: "static" detection) and conservative to avoid accidentally excluding dynamic routes.

Custom server entries may still bundle static modules if explicitly imported.

…m runtime bundle

vercel · 2026-03-01T08:43:20Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
waku	Ready	Preview	Mar 5, 2026 5:35am

codesandbox-ci · 2026-03-01T08:43:39Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

dai-shi

Thanks for working on it.

Instead of pruning static route modules after build, this change prevents fully static routes from entering the runtime module graph in the first place.

Sounds good.

We have waku/router on top of waku/minimal api. I wonder which is responsible to this capability. If it's waku/minimal related, we should work on it first, without caring waku/router much. (At least, the PR must be separated.)

dai-shi · 2026-03-03T04:35:05Z

packages/waku/src/lib/utils/managed.ts

+import path from 'node:path';
 import { EXTENSIONS, SRC_MIDDLEWARE, SRC_PAGES } from '../constants.js';

-export const getManagedServerEntry = (srcDir: string) => {


I'm not sure if I 100% follow the idea, but it shouldn't be managed mode only. So, changing code here seems not ideal.

dai-shi · 2026-03-03T04:37:24Z

packages/waku/src/router/create-pages.tsx

+    getConfigs: async (context?: { mode?: 'runtime' | 'build' }) => {
+      const mode = context?.mode || 'runtime';


The change here is not nice and not acceptable. only define-router should be responsible to this capability.

Thanks for pointing this out!

I've updated the implementation so that runtime/build filtering is handled entirely in define-router.
create-pages.tsx is now mode-agnostic as suggested.

Let me know if this looks better.

dai-shi · 2026-03-03T04:38:29Z

pnpm-workspace.yaml

Do not change this in this PR.

dai-shi · 2026-03-03T10:56:54Z

Actually, while not sure, this might be somewhat related with #1790, which I'm hoping to tackle sometime soon.

TiwariLokesh · 2026-03-05T05:07:01Z

Thanks for the feedback!

You're right - the current implementation mixes router-level responsibility with managed mode logic.

I'll revise the PR to:

revert the pnpm-workspace.yaml change
avoid modifying create-pages.tsx
move the runtime/build mode handling fully into define-router so that the capability is router-driven rather than managed-mode specific.

I'll push an updated version shortly.

TiwariLokesh · 2026-03-05T05:51:05Z

Thanks for the detailed review!

I've pushed an update addressing the feedback:

Reverted changes to pnpm-workspace.yaml
Removed mode-aware logic from create-pages.tsx
Removed managed-mode filtering
Moved runtime/build filtering entirely into define-router

Now create-pages simply constructs the route configs and define-router handles runtime/build separation internally.

Build verification:
pnpm --filter waku compile:code
pnpm --filter waku compile:types

Please let me know if there’s anything else I should adjust.

dai-shi

Please let me know if there’s anything else I should adjust.

Don't expect this to be merged very soon. There are many things to consider some design decisions as I noted.

Meanwhile, make this PR minimal. Please don't change unrelated files. Review changes before pushing. For now, the quality feels AI generation level.

dai-shi · 2026-03-05T06:29:25Z

packages/waku/src/lib/utils/managed.ts

@@ -1,5 +1,4 @@
 import { EXTENSIONS, SRC_MIDDLEWARE, SRC_PAGES } from '../constants.js';
-


remove changes in this file.

dai-shi · 2026-03-05T06:30:03Z

packages/waku/src/lib/vite-plugins/user-entries.ts

+        );
+        return resolved ? resolved : '\0' + source;
+      }
+      if (source === 'virtual:vite-rsc-waku/server-entry-build-inner') {


Any difference between -runtime-inner and -build-inner?

dai-shi · 2026-03-05T06:35:45Z

marking draft until we choose some design decisions.

feat: split runtime/build server entries to exclude static routes fro…

e7c118b

…m runtime bundle

vercel bot deployed to Preview March 1, 2026 08:44 View deployment

dai-shi requested changes Mar 3, 2026

View reviewed changes

refactor: move runtime/build filtering to define-router

36c068c

vercel bot deployed to Preview March 5, 2026 05:35 View deployment

dai-shi requested changes Mar 5, 2026

View reviewed changes

dai-shi marked this pull request as draft March 5, 2026 06:35

		getConfigs: async (context?: { mode?: 'runtime' \| 'build' }) => {
		const mode = context?.mode \|\| 'runtime';

		@@ -1,5 +1,4 @@
		import { EXTENSIONS, SRC_MIDDLEWARE, SRC_PAGES } from '../constants.js';

Uh oh!

Conversation

TiwariLokesh commented Mar 1, 2026

Summary

Motivation

What Changed

1. Runtime / Build Entry Split

2. Managed Mode Runtime Exclusion

3. Mode-Aware Router Resolution

4. Removed Post-Build Pruning

Result

Notes

Uh oh!

vercel bot commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codesandbox-ci bot commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dai-shi left a comment

Choose a reason for hiding this comment

Uh oh!

dai-shi Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

dai-shi Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

TiwariLokesh Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

dai-shi Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

dai-shi commented Mar 3, 2026

Uh oh!

TiwariLokesh commented Mar 5, 2026

Uh oh!

TiwariLokesh commented Mar 5, 2026

Uh oh!

dai-shi left a comment

Choose a reason for hiding this comment

Uh oh!

dai-shi Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

dai-shi Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

dai-shi commented Mar 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel bot commented Mar 1, 2026 •

edited

Loading

codesandbox-ci bot commented Mar 1, 2026 •

edited

Loading