Tune JMH configurations for stable measurements - #2050
Merged
Conversation
Increase forks, warmup iterations, and measurement iterations across all JMH benchmarks so the suite can reliably detect ~2% performance changes. Remove per-method fork overrides whose concerns are now covered by the higher class defaults. Update Javadoc to match. Suite wall-clock time increases from ~7 minutes to ~20 minutes: (+170%, ~2.7×). In my opinion, that extra time is reasonable in exchange for letting us make more trustworthy decisions about performance impacts of future changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2050 +/- ##
=========================================
Coverage 50.81% 50.81%
- Complexity 12761 12762 +1
=========================================
Files 1368 1368
Lines 83499 83499
Branches 14414 14414
=========================================
Hits 42431 42431
+ Misses 36385 36383 -2
- Partials 4683 4685 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
msridhar
approved these changes
Aug 31, 2026
msridhar
left a comment
msridhar
left a comment
Member
There was a problem hiding this comment.
100% agreed that more time for more accurate measurements is worthwhile. NullAway's JMH suite takes almost 1 hour to run, as a comparison.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase forks, warmup iterations, and measurement iterations across all JMH benchmarks so the suite can reliably detect ~2% performance changes. Remove per-method fork overrides whose concerns are now covered by the higher class defaults. Update Javadoc to match.
Suite wall-clock time increases from ~7 minutes to ~20 minutes: +170% or ~2.7×. In my opinion, that extra time is acceptable in exchange for letting us make more trustworthy decisions about performance impacts of future changes.