Update submodules to work with GCC 10#67
Open
julianhess wants to merge 6 commits into
Open
Conversation
We can't use Heng Li's latest, since Jeremiah made some changes to it.
walaj
reviewed
Dec 19, 2022
walaj
left a comment
walaj
left a comment
Owner
There was a problem hiding this comment.
Thanks Julian, I appreciate the help with this -- don't we still need the htslib submodule here though?
Contributor
Author
|
I made this PR against the |
Owner
|
Hi Julian -- so I'm looking back and I think I had made some of these submodule changes above that you suggested, but on the "cmake" branch. Do you use that branch or have capacity to see if that works on your system / fixes theses issues? |
Contributor
Author
|
I have not yet used that branch, but would be happy to switch over. Your message is really apropos; I'm actually hacking on a tool that uses SeqLib right now. |
Owner
|
That would be great if you could try it and see if that works, then I can
just move it over the main. I haven't built my own tool with SeqLib in a
while, you're the world expert on this now!
…On Tue, Jan 30, 2024 at 8:50 PM julianhess ***@***.***> wrote:
I have not yet used that branch, but would be happy to switch over. Your
message is really apropos; I'm actually hacking on a tool that uses SeqLib
right now.
—
Reply to this email directly, view it on GitHub
<#67 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABUZ7CAJGXJQHULLZZ2JVN3YRGPNNAVCNFSM6AAAAAATACF3JWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJYGIYTQMRVGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66