controllers-films-users. Создать модели данных и котроллеры. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…данных и котроллеры.
irek-valiev
reviewed
May 25, 2025
| private final Map<Long, Film> films = new HashMap<>(); | ||
|
|
||
| @GetMapping | ||
| public Collection<Film> findAll() { |
| @PostMapping | ||
| public Film create(@Valid @RequestBody Film film) { | ||
|
|
||
| if (film.getReleaseDate().isBefore(LocalDate.of(1895, 12, 28))) { |
There was a problem hiding this comment.
эта валидация нужна и при обновлении фильма, поэтому вынеси в отдельный метод
| log.debug("Пользователь с логином " + user.getLogin() + " уже существует"); | ||
| throw new ValidationException("Пользователь с логином " + user.getLogin() + " уже существует"); | ||
| } | ||
| if (user.getLogin().contains(" ")) { |
There was a problem hiding this comment.
эта проверка нужна и при обновлении пользователя, вынеси в отдельный метод
| log.debug("Логин должен быть без пробелов"); | ||
| throw new ValidationException("Логин должен быть без пробелов"); | ||
| } | ||
| if (user.getBirthday().isAfter(LocalDate.now())) { |
| } | ||
|
|
||
| user.setId(getNextId()); | ||
| if (user.getName() == null || user.getName().isBlank()) |
| @Size(max = 200) | ||
| private String description; | ||
|
|
||
| private LocalDate releaseDate; |
There was a problem hiding this comment.
для этого поля нужна аннотация @NotNull
| private LocalDate releaseDate; | ||
|
|
||
| @Positive | ||
| private Integer duration; |
| private Long id; | ||
|
|
||
| private String email; |
There was a problem hiding this comment.
для этого поля нужна аннотация @NotNull
| private String email; | ||
|
|
||
| @NotNull |
There was a problem hiding this comment.
лишняя аннотация, @notblank покроет и null, и пустую строку
|
|
||
| private String name; | ||
|
|
||
| private LocalDate birthday; |
There was a problem hiding this comment.
для этого поля нужна аннотация @NotNull
…модели данных и котроллеры.
irek-valiev
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавить зависимости spring. Создать модели данных и котроллеры.