add-friends-likes. Добавить новые методы для лайков и друзей. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walder86
force-pushed
the
add-friends-likes
branch
3 times, most recently
from
f2264e6 to
e1af25c
Compare
…ь хранилища. Добавить сервисы.
walder86
force-pushed
the
add-friends-likes
branch
from
e1af25c to
e0a8915
Compare
irek-valiev
reviewed
Jun 16, 2025
| import java.util.Map; | ||
| import java.util.List; | ||
|
|
||
| @Slf4j |
There was a problem hiding this comment.
в этом классе больше нет логирования
| import java.util.Map; | ||
| import java.util.List; | ||
|
|
||
| @Slf4j |
| import org.springframework.web.bind.annotation.RestControllerAdvice; | ||
|
|
||
| @RestControllerAdvice | ||
| public class ExceptionHandlerClass { |
| import java.time.LocalDate; | ||
| import java.util.List; | ||
|
|
||
| @Slf4j |
There was a problem hiding this comment.
добавь логи в те методы, где их нет
src/main/java/ru/yandex/practicum/filmorate/service/FilmService.java
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| public List<Film> getPopularFilms(Long count) { |
There was a problem hiding this comment.
добавь проверку, что count больше нуля
| import java.time.LocalDate; | ||
| import java.util.List; | ||
|
|
||
| @Slf4j |
There was a problem hiding this comment.
добавь логи в те методы, где их нет
| } | ||
|
|
||
| public User getUserById(Long userId) { | ||
| User user = userStorage.getUserById(userId); |
There was a problem hiding this comment.
вынеси получение пользователя/выброс исключения во внутренний метод, чтобы не повторяться
| log.info("Пользователь с id " + newUser.getId() + " обновлен"); | ||
| return oldUser; | ||
| } | ||
|
|
There was a problem hiding this comment.
для методов с друзьями вынеси из storage в сервис поверку существования пользователей
| import java.util.List; | ||
|
|
||
| public interface UserStorage { | ||
|
|
There was a problem hiding this comment.
в интерфейсах все методы по умолчанию являются public и явное указание это модификатора уже выглядит "маслом масляным"))
…ку из хранилищ в сервисы.
walder86
force-pushed
the
add-friends-likes
branch
from
c9b2034 to
a5ce0bb
Compare
irek-valiev
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавить хранилища. Добавить сервисы.