add-database. Добавить базу данных для сохранения сущностей. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irek-valiev
reviewed
Jun 22, 2025
| @RestController | ||
| @RequestMapping(value = "/genres") | ||
| @RequiredArgsConstructor | ||
| public class GenreController { |
| @RestController | ||
| @RequestMapping(value = "/mpa") | ||
| @RequiredArgsConstructor | ||
| public class RatingMPAController { |
| } | ||
|
|
||
| public Genre getById(Long id) { | ||
| if (storage.getById(id) == null) { |
There was a problem hiding this comment.
метод storage.getById() сам бросит исключение, если жанр не найден
| } | ||
|
|
||
| public RatingMPA getById(Long id) { | ||
| if (storage.getById(id) == null) { |
There was a problem hiding this comment.
запиши результат storage.getById() в переменную, чтобы не запрашивать еще раз из БД
|
|
||
| public void addOrUpdateUser(User user); | ||
| public void createUser(User user); | ||
|
|
There was a problem hiding this comment.
в интерфейсах все методы по умолчанию являются public и явное указание это модификатора уже выглядит "маслом масляным"))
…ненужный код при запросе жанров и рейтинга по id. Удалить модификаторы public в интерфейсах
irek-valiev
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.