[improve][fn] remove retry in AHC #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
…Impl。AsyncHttpConnector use maxRetry from ClientConfigurationData
walkinggo
force-pushed
the
remove-retry-in-AHC
branch
from
e8be60a to
6f6af02
Compare
walkinggo
force-pushed
the
remove-retry-in-AHC
branch
from
99232c6 to
f09b300
Compare
…ntBuilderImplTest.java Co-authored-by: Lari Hotari <[email protected]>
…ntBuilderImpl.java Co-authored-by: Lari Hotari <[email protected]>
…lientBuilder.java Co-authored-by: Lari Hotari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
###self check
Modifications
Retry Configuration Support
Added
maxRetryRequestTimesinClientConfigurationData(default: 5) to control admin client request retry behavior. Configuration propagates toAsyncHttpConnectorimplementations.Client API Enhancements
ClientBuilderinterface with newmaxRetryTimes()methodClientBuilderImplAsyncHttpConnectorto use centralized configuration instead of AsyncHttpClient's internal retry settingconfBuilder.setMaxRequestRetry(0)Added parameter verification test in
ClientBuilderImplTestto validate retry time configuration constraint