Fix notebook content accuracy#4
Merged
sanbuphy merged 1 commit intoJun 13, 2026
Merged
Conversation
leo-lilinxiao
force-pushed
the
fix/notebook-content-accuracy
branch
from
June 12, 2026 14:55
a92ede0 to
f69c497
Compare
Contributor
Author
|
@sanbuphy 你好!这个教程写得非常好,结构清晰,也很适合从零理解 LLM 核心组件,非常感谢开源这套内容~ 这次 PR 主要修了一些内容准确性和英文版中的小问题,例如 KV Cache 复杂度表述、英文 notebook 里的中英文残留/语法问题,以及少量依赖和目录数量同步。我已经 rebase 到最新 main,并重新跑过 notebook 解析、 辛苦有空帮忙检视一下代码,看看是否合适合入。谢谢! |
Contributor
|
LGTM 谢谢贡献 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tiktokento requirements for the tokenizer basics notebookWhy
A few tutorial sections used shorthand complexity claims that could mislead readers: KV Cache avoids recomputing historical K/V and hidden states, but the cache itself grows linearly with sequence length and decode still reads historical KV. The English notebooks also had a couple of small syntax/content artifacts that made the lessons less reliable.
Validation
git diff --checkast.parsenpm run build