Skip to content

Fix notebook content accuracy#4

Merged
sanbuphy merged 1 commit into
walkinglabs:mainfrom
leo-lilinxiao:fix/notebook-content-accuracy
Jun 13, 2026
Merged

Fix notebook content accuracy#4
sanbuphy merged 1 commit into
walkinglabs:mainfrom
leo-lilinxiao:fix/notebook-content-accuracy

Conversation

@leo-lilinxiao

Copy link
Copy Markdown
Contributor

Summary

  • clarify KV Cache complexity in the inference acceleration and long-context lessons
  • fix two English notebook code issues that prevented cells from parsing/running
  • replace several placeholder exercise sections with concrete practice tasks
  • update notebook counts and curriculum links to reflect the current 26-notebook layout
  • add tiktoken to requirements for the tokenizer basics notebook

Why

A few tutorial sections used shorthand complexity claims that could mislead readers: KV Cache avoids recomputing historical K/V and hidden states, but the cache itself grows linearly with sequence length and decode still reads historical KV. The English notebooks also had a couple of small syntax/content artifacts that made the lessons less reliable.

Validation

  • git diff --check
  • parsed all notebook code cells with Python ast.parse
  • npm run build

@leo-lilinxiao
leo-lilinxiao force-pushed the fix/notebook-content-accuracy branch from a92ede0 to f69c497 Compare June 12, 2026 14:55
@leo-lilinxiao

leo-lilinxiao commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

@sanbuphy 你好!这个教程写得非常好,结构清晰,也很适合从零理解 LLM 核心组件,非常感谢开源这套内容~

这次 PR 主要修了一些内容准确性和英文版中的小问题,例如 KV Cache 复杂度表述、英文 notebook 里的中英文残留/语法问题,以及少量依赖和目录数量同步。我已经 rebase 到最新 main,并重新跑过 notebook 解析、git diff --checknpm run build

辛苦有空帮忙检视一下代码,看看是否合适合入。谢谢!

@sanbuphy

Copy link
Copy Markdown
Contributor

LGTM 谢谢贡献

@sanbuphy
sanbuphy merged commit 7df3cd4 into walkinglabs:main Jun 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants