Fix for issue 339 #439
Open
Fix for issue 339 #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… deleted from the web UI. This fix was created with help from GitHub Copilot and GPT-4.1 The bug is caused by the sync logic not removing locally cached articles that have been deleted on the server (via the web UI). The root cause is the following: - The iOS app fetches all articles from the server and updates or inserts them locally. - It keeps track of the IDs of all articles received from the server in entriesSynced. - After syncing, it calls purge(), which deletes any local articles whose IDs are not in entriesSynced. - However, this purge is done in a background context and may not be saved or merged properly with the main context, or the UI may not be updated to reflect these deletions. The fix implements the following logic: - After purging deleted articles from the local database, changes are now saved and merged into the main context to ensure the UI updates and deleted articles are removed from the iOS app after a sync. Link to bug report: wallabag#339
… deleted from the web UI. The previous fix does not solve this issue, hence submitting this one, which was more thoroughly tested. It turns out that the bug is actually an edge case: articles are not synced only when the list of articles becomes empty on the server. This is because `purge()` has a guard testing for `entriesSynced.count == 0` which prevents the sync from happening in the iOS app. This commit removes the guard, enabling the correct syncing behavior. wallabag#339
|
Strange, I have tested your previous fix and have the correct behavior, I will test your new PR tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix I submitted does not solve this issue, hence submitting this one, which was more thoroughly tested. It turns out that the bug is actually an edge case: articles are not synced only when the list of articles becomes empty on the ser
ver. This is because
purge()has a guard testing forentriesSynced.count == 0which prevents the sync from happening in the iOS app. This commit removes the guard, enabling the correct syncing behavior.