Skip to content

github: return fake PR ID in dry-run-mode for craeatePr action #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2025
Merged

github: return fake PR ID in dry-run-mode for craeatePr action #186

merged 1 commit into from
Jan 31, 2025

Conversation

@brig
Copy link
Contributor

@brig brig commented Jan 30, 2025 •
edited
Loading

as a result, it will be possible to run in dry-run mode without making any changes:

...
- task: github
   in:
     action: createPr
   out: createResponse

- task: github
   in:
      action: closePr/mergePr/whatever  
      prId: "${createResponse.prId}"
...

@brig brig merged commit c360100 into master Jan 31, 2025
1 check passed
@brig brig deleted the brig/createpr-dry-run-result branch January 31, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benbroadaway benbroadaway benbroadaway approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brig @benbroadaway