github: list commits action #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbroadaway
previously approved these changes
Oct 7, 2025
ibodrov
previously approved these changes
Oct 7, 2025
tasks/git/src/test/java/com/walmartlabs/concord/plugins/git/client/GitHubClientTest.java
Outdated
Show resolved
Hide resolved
|
|
||
| var apiUrl = buildApiUrl(apiInfo.baseUrl(), path); | ||
| var requestUrl = appendParamsToUrl(apiUrl, effectiveParams); | ||
| while (requestUrl != null) { |
There was a problem hiding this comment.
When requestUrl is null? Should it instead be something like
while (true) {
var keepGoing = handler.onPage(...)
if (!keepGoing) {
break;
}
...etc
}There was a problem hiding this comment.
requestUrl = parseNextLink(response.headers().firstValue("Link").orElse(null));
We stop either when there are no more pages or when the handler indicates no further processing is needed
tasks/git/src/main/java/com/walmartlabs/concord/plugins/git/client/GitHubClient.java
Outdated
Show resolved
Hide resolved
ibodrov
approved these changes
Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.