concord-server: refactor WebSocketChannelManager, allow message sources in plugins #1056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibodrov
force-pushed
the
ib/dispatcher-ext
branch
4 times, most recently
from
cddfc83 to
53945a6
Compare
ibodrov
force-pushed
the
ib/dispatcher-ext
branch
2 times, most recently
from
59b9e36 to
ad60bed
Compare
mtkunkel
force-pushed
the
ib/dispatcher-ext
branch
from
ad60bed to
60462dc
Compare
ibodrov
force-pushed
the
ib/dispatcher-ext
branch
from
60462dc to
ecc83f7
Compare
ibodrov
force-pushed
the
ib/dispatcher-ext
branch
from
ecc83f7 to
2098da1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A different to #1055 approach. Now server plugins can implement
com.walmartlabs.concord.server.websocket.MessageChanneland provide their own process requests. Which, for example, allows for alternative methods of process dispatching in addition to the regular PROCESS_QUEUE -> websockets -> agents route.Changes: