Skip to content

Conversation

@ibodrov
Copy link
Collaborator

@ibodrov ibodrov commented Jul 2, 2025

Refactor agent configuration of v1 and v2 "runners". Now it is possible to add additional "runners" in an external config:

concord-agent {
    runnerV3 = ${runner} # reference to the existing common block of options
    runnerV3 {
        path = "/path/to/runner.jar"
        mainClass = "com.acme.runtime.v3.runner.Main"
        segmentedLogs = true
    }

    runtimes = {
       "concord-v3" = ${runnerV3}
        # will be merged with "concord-v1" and "concord-v2" keys
    }
}

@ibodrov ibodrov requested a review from a team July 2, 2025 17:07
@brig
Copy link
Contributor

brig commented Jul 6, 2025

Do we want anything regarding backward compatibility?

brig
brig previously approved these changes Jul 7, 2025
@ibodrov ibodrov marked this pull request as draft July 7, 2025 20:07
@ibodrov ibodrov force-pushed the ib/agent-pluggable-runtimes branch from a4a7429 to 8e39180 Compare July 25, 2025 12:19
@ibodrov ibodrov force-pushed the ib/agent-pluggable-runtimes branch from 8e39180 to 924badb Compare July 25, 2025 12:21
@ibodrov ibodrov marked this pull request as ready for review July 25, 2025 12:21
@ibodrov ibodrov requested a review from a team July 25, 2025 12:21
@ibodrov
Copy link
Collaborator Author

ibodrov commented Jul 25, 2025

Removed the nested blocks in favor of simpler backward-compatibility with existing concord-agent.confs.

@ibodrov ibodrov merged commit e05ccea into master Aug 5, 2025
4 checks passed
@ibodrov ibodrov deleted the ib/agent-pluggable-runtimes branch August 5, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants