Skip to content

concord-cli: ignore unknown properties in the CLI config file #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 12, 2025
Merged

concord-cli: ignore unknown properties in the CLI config file #1203

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
95116aa
concord-cli: ignore unknown properties in the CLI config file
ibodrov Aug 11, 2025
12e7c2d
Merge branch 'master' into ib/no-fail-on-unknown
ibodrov Aug 11, 2025
2d94ae0
Merge branch 'master' into ib/no-fail-on-unknown
benbroadaway Aug 12, 2025
820fe82
Merge branch 'master' into ib/no-fail-on-unknown
ibodrov Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cli/src/main/java/com/walmartlabs/concord/cli/CliConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
* =====
*/

import com.fasterxml.jackson.databind.DeserializationFeature;
import com.fasterxml.jackson.databind.JsonMappingException;
import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.node.ObjectNode;
Expand All @@ -38,7 +39,8 @@
public record CliConfig(Map<String, CliConfigContext> contexts) {

public static CliConfig load(Path path) throws IOException {
var mapper = new YAMLMapper();
var mapper = new YAMLMapper()
.disable(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES);

JsonNode defaults = mapper.readTree(readDefaultConfig());

Expand Down